refactor: simplify job dispatch controller#839
Merged
adityachoudhari26 merged 17 commits intomainfrom Mar 9, 2026
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (24)
Disabled knowledge base sources:
📝 WalkthroughWalkthroughThis PR refactors the job dispatch system to use direct Job-based workflows instead of ReleaseTarget abstractions. It introduces a reconcile Queue-based optional job dispatch mechanism, simplifies data access patterns with granular getters (GetJob, GetRelease, GetDeployment, GetJobAgent), and removes legacy job agent selection logic. Changes
Sequence Diagram(s)sequenceDiagram
participant Controller as Job Dispatch<br/>Controller
participant Getter as PostgresGetter
participant DB as Database
participant Reconcile as Reconcile<br/>Function
participant Dispatcher as Job<br/>Dispatcher
participant Setter as PostgresSetter
Controller->>Getter: GetJob(ctx, jobID)
Getter->>DB: Query job by ID
DB-->>Getter: Job record
Getter-->>Controller: *oapi.Job
Controller->>Reconcile: Reconcile(ctx, getter, setter,<br/>verifier, dispatcher, job)
Reconcile->>Getter: GetRelease(ctx, job.ReleaseId)
Getter->>DB: Query release by ID
DB-->>Getter: Release record
Getter-->>Reconcile: *oapi.Release
Reconcile->>Getter: GetDeployment(ctx, release.DeploymentId)
Getter->>DB: Query deployment by ID
DB-->>Getter: Deployment record
Getter-->>Reconcile: *oapi.Deployment
Reconcile->>Getter: GetJobAgents(ctx, release.Id)
Getter->>DB: Query job agents for release
DB-->>Getter: JobAgent records
Getter-->>Reconcile: []oapi.JobAgent
Reconcile->>Getter: GetVerificationPolicies(ctx, releaseTarget)
Getter->>DB: Query policies & rules
DB-->>Getter: VerificationMetricSpec list
Getter-->>Reconcile: []oapi.VerificationMetricSpec
Reconcile->>Dispatcher: Dispatch(ctx, job)
Dispatcher-->>Reconcile: error (if any)
Reconcile->>Setter: CreateVerifications(ctx, job, specs)
Setter->>DB: Insert verification metrics
DB-->>Setter: Completed
Setter-->>Reconcile: error (if any)
Reconcile-->>Controller: *ReconcileResult
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
Suggested reviewers
✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…b-dispatch-controller
…b-dispatch-controller
…b-dispatch-controller
…b-dispatch-controller
zacharyblasczyk
added a commit
that referenced
this pull request
Mar 9, 2026
Replace panic-prone uuid.MustParse calls with proper uuid.Parse error handling across stable production code in workspace-engine. This prevents runtime panics from invalid UUID strings by returning descriptive errors instead. Follows the pattern established in commit 5888d08. Scope: - pkg/store/ (environment, deployment, resource, system, policies, resources) - svc/controllers/jobverificationmetric/ (getters and setters) - svc/controllers/environmentresourceselectoreval/controller.go - pkg/workspace/releasemanager/policy/evaluator/ (approval, deploymentwindow, environmentprogression, versioncooldown) Excluded: - svc/controllers/jobdispatch/ (in flux from #839) - Functions that don't return error (would require interface changes) - Test files - deploymentdependency evaluator (functions don't return error) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
4 tasks
This was referenced Mar 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
New Features
Refactor