Policies tab view

[jsbroks]

Add a new 'Policies' tab to the deployment details page to display policies and their associated resources.

---

 

Summary by CodeRabbit

New Features

• Added a "Policies" tab to the deployment navigation interface
• Introduced a new policies page displaying deployment policy details, including rules, targets, enabled/disabled status, priority, and related resources

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR adds a "policies" tab to the deployment navbar and introduces a new policies page for displaying deployment policy details. The page fetches policies and release targets, displays them in a collapsible table structure showing policy metadata, rules, and associated resources.

Changes

Cohort / File(s)	Summary
Deployment Navigation apps/web/app/routes/ws/deployments/_components/DeploymentsNavbarTabs.tsx	Added "policies" to the DeploymentTab union type and extended the route recognition logic to identify the /policies path, registering the new tab in the navbar tabs system.
Policies Page Implementation apps/web/app/routes/ws/deployments/page.$deploymentId.policies.tsx	New page component fetching and displaying deployment policies with collapsible policy groups showing rule details, targets, and associated resources. Includes helper functions for formatting rule details, selectors, and resource descriptions.

Sequence Diagram

sequenceDiagram
    participant User as User
    participant Page as DeploymentPolicies<br/>Page
    participant TRPC as TRPC Client
    participant Render as Policy Renderer
    
    User->>Page: Navigate to /deployments/{id}/policies
    Page->>TRPC: Fetch policies list
    TRPC-->>Page: Return policies data
    Page->>TRPC: Fetch release targets
    TRPC-->>Page: Return targets mapping
    Page->>Page: Sort policies by name
    Page->>Page: Resolve targets per policy<br/>(match policy to targets)
    Page->>Render: Map policies to<br/>PolicyReleaseTargetsGroup
    Render->>Render: For each policy:<br/>render metadata, rules,<br/>and resources
    Render-->>User: Display policy table<br/>with collapsible details
    User->>Render: Toggle policy expansion
    Render->>Render: Show/hide rules<br/>and resources
    Render-->>User: Update view

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• chore: update deployment cel ui #699: Modifies the same DeploymentsNavbarTabs.tsx file to extend the DeploymentTab union and add tab-selection logic for the new "policies" tab.

Poem

🐰 A new tab hops into view,
Policies displayed in rows anew,
With rules and targets all aligned,
Resources linked, details refined,
The navbar grows, the code runs true! 🌿

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch cursor/policies-tab-view-021a

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}