perf: only add new release targets to evaluate queue

[adityachoudhari26]

Summary by CodeRabbit

• Refactor
  • Updated processing logic to focus on newly created release targets instead of matched ones, affecting how results are returned and how downstream jobs are dispatched.

[coderabbitai]

Walkthrough

The code in the compute-systems-release-targets worker has been updated to change the focus from "matched" release targets to "created" release targets. The transaction block now returns a list of newly created and deleted release targets, removing the previous logic that queried for matched targets after insertion. Subsequent logic and function calls have been updated to use the "created" targets for further processing and job dispatching, replacing all references to "matched" with "created".

Changes

File(s)	Change Summary
apps/event-worker/src/workers/compute-systems-release-targets.ts	Changed transaction return from { matched, deleted } to { created, deleted }. Updated downstream logic to use created instead of matched for further processing and job dispatching. Removed querying for matched targets after insertion.

Sequence Diagram(s)

sequenceDiagram
    participant Worker as ComputeSystemsReleaseTargets Worker
    participant DB as Database
    participant Dispatcher as dispatchEvaluateJobs

    Worker->>DB: Insert new release targets
    DB-->>Worker: Return { created, deleted }
    alt If created.length === 0
        Worker-->>Worker: Skip further processing
    else If created.length > 0
        Worker->>Dispatcher: dispatchEvaluateJobs(created)
    end

Loading

Possibly related PRs

• fix: actually delete unmatched release targets #525: Modifies transaction return structure and downstream logic in the same file, focusing on related release target workflow changes.
• chore: Readd resource workers #477: Updates insertion and upsert handling for release targets, affecting related processing logic in different modules.
• fix: stabilize release creation and add e2e #518: Alters transaction handling and job dispatching logic for release targets, similar to the changes in this PR.

Suggested reviewers

• jsbroks

Poem

A hop and a skip, new targets in tow,
The worker now tracks what’s fresh in the row.
No more matched, just created, we see—
Dispatching with glee, as quick as can be!
Deleted ones gone, the new ones parade,
In the field of releases, progress is made.
🐇✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4e9feab and 5f4ddf4.

📒 Files selected for processing (1)

• apps/event-worker/src/workers/compute-systems-release-targets.ts (4 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.{ts,tsx}`: **Note on Error Handling:** Avoid strict enforcement of try/catch blocks. Code may use early returns, Promise chains (.then().catch()), or other patterns for error...

**/*.{ts,tsx}: Note on Error Handling:
Avoid strict enforcement of try/catch blocks. Code may use early returns, Promise chains (.then().catch()), or other patterns for error handling. These are acceptable as long as they maintain clarity and predictability.

• apps/event-worker/src/workers/compute-systems-release-targets.ts

🧬 Code Graph Analysis (1)

apps/event-worker/src/workers/compute-systems-release-targets.ts (2)

packages/db/src/client.ts (1)

• db (15-15)

apps/event-worker/src/utils/dispatch-evaluate-jobs.ts (1)

• dispatchEvaluateJobs (5-11)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Lint
• GitHub Check: Typecheck
• GitHub Check: build (linux/amd64)

🔇 Additional comments (4)

apps/event-worker/src/workers/compute-systems-release-targets.ts (4)

83-83: Great performance optimization: Focus on created targets

Refocusing on the created release targets rather than matched ones will improve performance by eliminating the need to query for matched targets after insertion.

---

157-157: Correctly returning created targets instead of matched

This change aligns with the variable renaming and performance optimization focus. The transaction now directly returns the newly created release targets instead of requiring an additional query.

---

166-166: Consistent conditional check

The early return condition has been properly updated to check for newly created targets, maintaining the logical flow of the function while focusing only on new targets.

---

187-187: Performance improvement: Only evaluate new targets

This change aligns perfectly with the PR objective. By only dispatching evaluate jobs for newly created targets instead of all matched targets, you're reducing unnecessary processing and improving performance.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.