perf: optimize version retrieval

[adityachoudhari26]

Summary by CodeRabbit

• Refactor
  • Refined the backend data retrieval process for fetching version details along with associated metadata.
  • The improvements streamline data handling and enhance the clarity of processing tasks.
  • As a result, users may experience remarkably improved responsiveness and consistency in overall performance across related workflows.

[coderabbitai]

Walkthrough

The changes update the findVersionsForEvaluate method in the VersionReleaseManager class. The method now imports inArray from the database module and removes the previous .then() chaining for processing the query results. It directly returns the results from the findMany call, extracts versionIds from these results, and uses them to fetch associated metadata in a separate query. The final result is constructed by mapping over the versions and enriching each with its corresponding metadata.

Changes

File(s)	Change Summary
packages/rule-engine/.../version-manager.ts	Modified findVersionsForEvaluate: added inArray import, removed chained .then() calls, directly returned results from findMany, and altered metadata mapping.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant VM as VersionReleaseManager
    participant DB as Database
    participant MA as Metadata Query (inArray)

    C->>VM: findVersionsForEvaluate()
    VM->>DB: Call findMany(query)
    DB-->>VM: Return versions list (with versionIds)
    VM->>MA: Query metadata using inArray(versionIds)
    MA-->>VM: Return metadata list
    VM->>C: Return enriched version objects

Loading

Poem

Hop, hop—code's in bloom today,
I, a rabbit, leap in a joyful way.
Version IDs and metadata now dance as one,
Streamlined queries and clean logic fun.
With every hop, my code sings anew—
Celebrate these changes; carrots for you!

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b8152f and eae9529.

📒 Files selected for processing (1)

• packages/rule-engine/src/manager/version-manager.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.{ts,tsx}`: **Note on Error Handling:** Avoid strict enforcement of try/catch blocks. Code may use early returns, Promise chains (.then().catch()), or other patterns for error...

**/*.{ts,tsx}: Note on Error Handling:
Avoid strict enforcement of try/catch blocks. Code may use early returns, Promise chains (.then().catch()), or other patterns for error handling. These are acceptable as long as they maintain clarity and predictability.

• packages/rule-engine/src/manager/version-manager.ts

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: Typecheck
• GitHub Check: build (linux/amd64)
• GitHub Check: Lint
• GitHub Check: build (linux/amd64)

🔇 Additional comments (4)

packages/rule-engine/src/manager/version-manager.ts (4)

10-10: Good addition of the inArray import.

Adding the inArray operator from the database module enables more efficient querying of metadata records for multiple versions.

---

123-148: Clean refactoring of the version query.

The refactored version query improves readability by using async/await instead of Promise chaining. The query logic remains correct while enhancing code clarity.

---

150-153: Excellent performance optimization.

This change significantly improves performance by replacing potential N+1 queries with a single batch query for metadata. Using inArray to fetch all metadata at once is much more efficient than fetching metadata for each version individually.

---

160-168: Clean and efficient result construction.

The new approach for constructing the result is clear and efficient. By mapping over versions and enriching each with its corresponding metadata, you've improved both the organization and readability of the code.

Two minor considerations:

1. The metadata filtering operation (filter + map) on line 163-164 will be O(n²) in worst case if there are many metadata entries per version.
2. The limit of 1,000 versions (line 147) might lead to memory pressure when constructing result with metadata.

If metadata per version ratio is high (many metadata entries per version), consider this optimization:

- return versions.map((v) => {
-   const versionMetadata = Object.fromEntries(
-     allMetadata
-       .filter((m) => m.versionId === v.id)
-       .map((m) => [m.key, m.value]),
-   );
- 
-   return { ...v, metadata: versionMetadata };
- });
+ // Group metadata by versionId first (single pass)
+ const metadataByVersionId = allMetadata.reduce((acc, m) => {
+   if (!acc[m.versionId]) acc[m.versionId] = [];
+   acc[m.versionId].push([m.key, m.value]);
+   return acc;
+ }, {});
+
+ // Then use the pre-grouped metadata 
+ return versions.map((v) => ({
+   ...v,
+   metadata: Object.fromEntries(metadataByVersionId[v.id] || [])
+ }));

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.