fix: Add skeletons on systems page

[adityachoudhari26]

Summary by CodeRabbit

• New Features

  • Enhanced visual loading indicators across deployment and environment views, replacing plain text with skeleton placeholders for a smoother experience.

• Refactor

  • Updated component organization to streamline internal structure.

• Style

  • Optimized table header widths for a more balanced and consistent layout.

[coderabbitai]

Walkthrough

This pull request updates several UI components and reorganizes file imports. The changes include updating the import paths for components such as DeleteSystemDialog and SystemDeploymentTable to reflect a new, more general file structure. Additionally, the implementation of loading states has been enhanced across components by replacing text-based indicators with skeleton loaders. A new skeleton component for table layouts has also been introduced, and adjustments to table styling have been made to improve layout consistency.

Changes

File(s)	Change Summary
apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/[systemSlug]/(sidebar)/settings/page.tsx apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/system-deployment-table/SystemDeploymentTable.tsx	Updated import for DeleteSystemDialog from a system-specific path to a generalized path (~/app/[workspaceSlug]/(appv2)/_components/system/DeleteSystemDialog).
apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/page.tsx	Modified import for SystemDeploymentTable, moving it from a dynamic [systemSlug] subdirectory to a clearly defined system-deployment-table folder.
apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/[systemSlug]/_components/deployments/environment-cell/DeploymentEnvironmentCell.tsx	Replaced plain text "Loading..." with a visually appealing skeleton loader in both DeploymentEnvironmentCell and its lazy variant.
apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/system-deployment-table/SystemDeploymentSkeleton.tsx	Introduced a new React functional component SystemDeploymentSkeleton that renders a skeleton loading state for a table layout.
apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/system-deployment-table/SystemDeploymentTable.tsx	Added an isLoading flag to conditionally render either the loading skeleton (SystemDeploymentSkeleton) or the actual DeploymentTable; also updated the DeleteSystemDialog import path.
apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/system-deployment-table/TableDeployments.tsx	Adjusted styling by setting fixed widths for TableHead elements and adding a flexible TableCell to improve the overall table layout.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SDT as SystemDeploymentTable
    participant DS as Data Service
    participant SDS as SystemDeploymentSkeleton
    participant DT as DeploymentTable

    User->>SDT: Request deployment view
    SDT->>DS: Fetch environments & deployments
    alt While loading
        SDT->>SDS: Render skeleton state
    else Data loaded
        SDT->>DT: Render complete DeploymentTable
    end

Loading

Suggested reviewers

• jsbroks

Poem

I'm a jaunty rabbit, coding through the night,
Hopping over paths to make our UI bright.
Skeletons now shimmer where loading once lay,
Imports now prance in a sleek, new display.
With bounces and bytes, our code sings with delight!
🐰✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d571a2 and 189d077.

📒 Files selected for processing (6)

• apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/[systemSlug]/(sidebar)/settings/page.tsx (1 hunks)
• apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/[systemSlug]/_components/deployments/environment-cell/DeploymentEnvironmentCell.tsx (3 hunks)
• apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/page.tsx (1 hunks)
• apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/system-deployment-table/SystemDeploymentSkeleton.tsx (1 hunks)
• apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/system-deployment-table/SystemDeploymentTable.tsx (3 hunks)
• apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/system-deployment-table/TableDeployments.tsx (3 hunks)

✅ Files skipped from review due to trivial changes (2)

• apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/page.tsx
• apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/system-deployment-table/TableDeployments.tsx

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.{ts,tsx}`: **Note on Error Handling:** Avoid strict en...

**/*.{ts,tsx}: Note on Error Handling:
Avoid strict enforcement of try/catch blocks. Code may use early returns, Promise chains (.then().catch()), or other patterns for error handling. These are acceptable as long as they maintain clarity and predictability.

• apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/system-deployment-table/SystemDeploymentSkeleton.tsx
• apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/[systemSlug]/_components/deployments/environment-cell/DeploymentEnvironmentCell.tsx
• apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/[systemSlug]/(sidebar)/settings/page.tsx
• apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/system-deployment-table/SystemDeploymentTable.tsx

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Typecheck
• GitHub Check: Lint
• GitHub Check: build (linux/amd64)

🔇 Additional comments (9)

apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/[systemSlug]/(sidebar)/settings/page.tsx (1)

15-15: Component import path updated correctly.

The import path for the DeleteSystemDialog component has been updated to use the more general components directory structure, which aligns with the overall component organization approach in the codebase.

apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/system-deployment-table/SystemDeploymentSkeleton.tsx (1)

1-48: Well-structured skeleton component for improved loading UX.

The SystemDeploymentSkeleton component provides a clean and consistent loading state for the deployment table. The approach of using skeleton placeholders offers a much better user experience than generic loading text.

A few observations:

• Good use of array mapping to generate repetitive skeleton elements
• Consistent styling with the actual table component
• Proper structure that mimics the loaded content

apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/[systemSlug]/_components/deployments/environment-cell/DeploymentEnvironmentCell.tsx (3)

14-14: Importing Skeleton component for loading states.

Added import for the Skeleton component that will be used to replace text-based loading indicators.

---

53-61: Enhanced loading state with skeleton placeholders.

Replaced the previous text-based loading indicator with skeleton placeholders, providing a more visually appealing and informative loading state.

---

197-205: Consistent loading state in LazyDeploymentEnvironmentCell.

Applied the same skeleton placeholder pattern to the LazyDeploymentEnvironmentCell component, ensuring consistency in loading state representation throughout the application.

apps/webservice/src/app/[workspaceSlug]/(appv2)/systems/system-deployment-table/SystemDeploymentTable.tsx (4)

17-17: Updated import path for DeleteSystemDialog.

The import path for the DeleteSystemDialog component has been updated to use the more general components directory structure, consistent with other files in the codebase.

---

19-19: Added import for the new skeleton component.

Imported the SystemDeploymentSkeleton component to handle loading states in the deployment table.

---

34-35: Added loading state tracking.

Created a new variable to track the loading status of both environments and deployments data, which is used to conditionally render the skeleton loading state.

---

76-90: Improved loading state implementation with conditional rendering.

Enhanced the component to show a skeleton loading state when data is being fetched, providing better visual feedback to users. The conditional rendering ensures the table is only displayed when data is available.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.