fix: Correct retry logic

[adityachoudhari26]

Summary by CodeRabbit

• Refactor
  • Streamlined the process for handling job failures by removing outdated dispatch logic.
  • Enhanced filtering criteria to ensure only relevant job triggers are processed, improving overall system reliability and efficiency.

[coderabbitai]

Walkthrough

The update streamlines job failure processing in the job dispatch module by removing the dispatchJobsForNewerRelease function and simplifying the logic within onJobFailure. The new logic omits fetching the latest release for comparison and directly applies refined conditions to the query for release job triggers. This involves checking matching environmentId and resourceId, and excluding the current job trigger using the newly imported ne operator. The changes ensure that only the correct, relevant triggers are considered during job failure processing.

Changes

File	Change Summary
packages/job-dispatch/src/job-failure.ts	Removed the dispatchJobsForNewerRelease function. Modified onJobFailure to remove logic for determining the latest release. Updated query conditions to filter release job triggers using matching environmentId, resourceId, and exclusion of the current trigger (using the ne operator from @ctrlplane/db).

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant JF as Job Failure Event
    participant OF as onJobFailure Function
    participant DB as Database Query (releaseJobTriggers)

    JF->>OF: Trigger job failure processing
    OF->>DB: Query triggers (environmentId, resourceId, exclude current)
    DB-->>OF: Return matching job triggers
    OF->>JF: Complete processing

Loading

Possibly related PRs

• fix: Deploy release if it is after latest non-pending #200: Involved adjustments to job trigger filtering logic and evaluation of job policies, which relates closely to the removal of the dispatchJobsForNewerRelease function and modifications in onJobFailure.

Suggested reviewers

• jsbroks

Poem

I'm a rabbit, hopping along the code trail,
With changes so tidy, I'll never fail.
Removed old functions with a swift bound,
New queries and logic now clearly found.
🐇 Cheers to updates that make the system click,
CodeRabbit sings with joy—oh, so slick!
🥕 Keep on coding, let your commits never derail!

Tip

CodeRabbit's docstrings feature is now available as part of our Pro Plan! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/job-dispatch/src/job-failure.ts (1)

30-42: Consider concurrency handling for parallel job failures.
While the logic here correctly excludes the current trigger from counting, multiple simultaneous job failures could create triggers concurrently if they each see releaseJobTriggerCount as below the threshold. Consider adding a database-level constraint or other concurrency controls to prevent duplicate triggers.

Would you like me to propose a solution (e.g., transactional checks or unique constraints) to address potential race conditions?

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4482389 and f128447.

📒 Files selected for processing (1)

• packages/job-dispatch/src/job-failure.ts (3 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

`**/*.{ts,tsx}`: **Note on Error Handling:** Avoid strict en...

**/*.{ts,tsx}: Note on Error Handling:
Avoid strict enforcement of try/catch blocks. Code may use early returns, Promise chains (.then().catch()), or other patterns for error handling. These are acceptable as long as they maintain clarity and predictability.

• packages/job-dispatch/src/job-failure.ts

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Typecheck
• GitHub Check: Lint
• GitHub Check: build (linux/amd64)