fix: Use left join on resource to make it nullable

[adityachoudhari26]

Summary by CodeRabbit

• Bug Fixes

  • Improved error handling for resource fetching, enhancing reliability.

• Refactor

  • Streamlined query logic for fetching relationships, improving clarity and potential performance.
  • Simplified mapping of relationships to resource data for better maintainability.

[coderabbitai]

Walkthrough

The changes in this pull request involve modifications to the resourceRouter within packages/api/src/router/resources.ts. The error handling in the getNodesRecursivelyHelper function has been simplified by removing the try-catch block. The logic for fetching relationships has been updated to utilize a more direct query approach with a select statement and a where clause, enhancing clarity. The overall structure of the router remains unchanged, maintaining core functionalities while improving code readability and maintainability.

Changes

File Path	Change Summary
packages/api/src/router/resources.ts	Simplified error handling in getNodesRecursivelyHelper by removing try-catch block; updated relationship fetching logic to use a select statement with a where clause, enhancing clarity and performance; retained mapping of relationships to include resource data in a more concise manner.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant ResourceRouter
    participant Database

    Client->>ResourceRouter: Request to get nodes
    ResourceRouter->>Database: Select nodes with where clause
    Database-->>ResourceRouter: Return nodes
    ResourceRouter-->>Client: Send nodes response

Loading

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

packages/api/src/router/resources.ts (2)

505-507: Fix indentation in the join condition

The indentation of the join condition parameters appears inconsistent with the surrounding code.

-        schema.jobResourceRelationship.resourceIdentifier,
-        schema.resource.identifier,
+      schema.jobResourceRelationship.resourceIdentifier,
+      schema.resource.identifier,

---

521-530: Consider handling large result sets

While the parallel processing of child nodes is efficient, consider implementing batch processing for large result sets to prevent potential memory issues.

Consider adding a batch size limit:

+  const BATCH_SIZE = 50;
   const childrenPromises = relationships.map((r) =>
     getNodeDataForResource(db, r.resource.id),
   );
-  const children = await Promise.all(childrenPromises);
+  const children = [];
+  for (let i = 0; i < childrenPromises.length; i += BATCH_SIZE) {
+    const batch = await Promise.all(
+      childrenPromises.slice(i, i + BATCH_SIZE)
+    );
+    children.push(...batch);
+  }

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 10b48bd and 11ef1b4.

📒 Files selected for processing (1)

• packages/api/src/router/resources.ts (1 hunks)

🔇 Additional comments (2)

packages/api/src/router/resources.ts (2)

493-498: LGTM: Clean and efficient job extraction logic

The base case handling and job extraction logic is well-structured, using appropriate array operations for flattening nested data.

---

499-518: LGTM: Correct implementation of nullable resource relationships

The left join implementation correctly handles nullable resources, aligning with the PR objective. The subsequent filtering ensures type safety.