Skip to content

Revert "[StepSecurity] Apply security best practices"#7379

Merged
alexprudhomme merged 1 commit intomainfrom
revert-7371-chore/GHA-090918-stepsecurity-remediation
Apr 9, 2026
Merged

Revert "[StepSecurity] Apply security best practices"#7379
alexprudhomme merged 1 commit intomainfrom
revert-7371-chore/GHA-090918-stepsecurity-remediation

Conversation

@alexprudhomme
Copy link
Copy Markdown
Contributor

@alexprudhomme alexprudhomme commented Apr 9, 2026

Reverts #7371

Why

The StepSecurity PR (#7371) replaced changesets/action with step-security/changeset-action. This broke the "Create release" CD workflow with:

Error: Unexpected executable file at .husky/pre-commit, GitHub API only supports non-executable files and directories.

Root cause

The upstream changesets/action includes fix #563"Don't error on symlinks and executables when they don't have to be touched anyway" (commit).

The step-security/changeset-action fork is missing this fix. Their automated cherry-pick workflow (PR #70) picked up upstream commits #545, #566, and #564, but skipped #563 — likely due to a merge conflict with their own audit/vulnerability patches.

Upstream issue

Filed: step-security/changeset-action#75

Once the fork picks up the missing fix, StepSecurity can re-propose the action swap.

KIT-282

@louis-bompart
Copy link
Copy Markdown
Collaborator

(please explain why, prolly someone from sec that'll stumble here eventually)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the previous StepSecurity change for the Changesets release step in the CD workflow, restoring the upstream Changesets GitHub Action used for creating release PRs and publishing.

Changes:

  • Replace step-security/changeset-action with changesets/action in the release workflow step.

@alexprudhomme
Copy link
Copy Markdown
Contributor Author

(please explain why, prolly someone from sec that'll stumble here eventually)

Done 👍

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 9, 2026

Open in StackBlitz

@coveo/atomic

npm i https://pkg.pr.new/@coveo/atomic@7379

@coveo/atomic-hosted-page

npm i https://pkg.pr.new/@coveo/atomic-hosted-page@7379

@coveo/atomic-legacy

npm i https://pkg.pr.new/@coveo/atomic-legacy@7379

@coveo/atomic-react

npm i https://pkg.pr.new/@coveo/atomic-react@7379

@coveo/auth

npm i https://pkg.pr.new/@coveo/auth@7379

@coveo/bueno

npm i https://pkg.pr.new/@coveo/bueno@7379

@coveo/create-atomic

npm i https://pkg.pr.new/@coveo/create-atomic@7379

@coveo/create-atomic-component

npm i https://pkg.pr.new/@coveo/create-atomic-component@7379

@coveo/create-atomic-component-project

npm i https://pkg.pr.new/@coveo/create-atomic-component-project@7379

@coveo/create-atomic-result-component

npm i https://pkg.pr.new/@coveo/create-atomic-result-component@7379

@coveo/create-atomic-rollup-plugin

npm i https://pkg.pr.new/@coveo/create-atomic-rollup-plugin@7379

@coveo/headless

npm i https://pkg.pr.new/@coveo/headless@7379

@coveo/headless-react

npm i https://pkg.pr.new/@coveo/headless-react@7379

@coveo/shopify

npm i https://pkg.pr.new/@coveo/shopify@7379

commit: 8b19207

@svcsnykcoveo
Copy link
Copy Markdown

svcsnykcoveo commented Apr 9, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@alexprudhomme alexprudhomme added this pull request to the merge queue Apr 9, 2026
Merged via the queue into main with commit f89fe5e Apr 9, 2026
54 of 55 checks passed
@alexprudhomme alexprudhomme deleted the revert-7371-chore/GHA-090918-stepsecurity-remediation branch April 9, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants