install.sh: Allow installing directly onto a remote host#2183
Merged
nhooyr merged 1 commit intocoder:masterfrom Oct 9, 2020
nhooyr:remote-install-2-f3e5
Merged
install.sh: Allow installing directly onto a remote host#2183nhooyr merged 1 commit intocoder:masterfrom nhooyr:remote-install-2-f3e5
nhooyr merged 1 commit intocoder:masterfrom
nhooyr:remote-install-2-f3e5
Conversation
code-asher
requested changes
Oct 9, 2020
Member
code-asher
left a comment
There was a problem hiding this comment.
I gave it a spin and it works like a dream. 🔥
| OPTIONAL \ | ||
| ALL_FLAGS | ||
|
|
||
| ALL_FLAGS="" |
Member
There was a problem hiding this comment.
We'll need to set SSH_ARGS as well I think to avoid unbound errors.
|
|
||
| if [ "$SSH_ARGS" ]; then | ||
| echoh "Installing remotely with ssh $SSH_ARGS" | ||
| curl -fsSL https://code-server.dev/install.sh | prefix "$SSH_ARGS" ssh "$SSH_ARGS" sh -s -- "$ALL_FLAGS" |
Member
There was a problem hiding this comment.
Ahh no need to mess with sh_c and all that with this method. Nice!!
Updates #1729 To fully close that issue see the various TODOs.
code-asher
approved these changes
Oct 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #1729
To fully close that issue see the various TODOs.