Open file-link in markdown preview

[HenningCash]

• code-server version: happens in v1 and v2 (see description)
• OS Version: irrelevant

Description

If you put a file-link into a markdown like Please open [file.js](./file.js) and open the preview code-server will produce links like:

• v1: http://localhost:8080/resource/home/coder/project/README.md
• v2: http://localhost:8080/webview/vscode-resource/home/coder/project/README.md

The original VSCode desktop handles these links like expected and opens the file in the current workspace.

[sr229]

@code-asher

[code-asher]

It appears to work now in 2.1698; probably fixed when we upgraded VS Code. Please let me know if that's not the case for you.

[code-asher]

Ahh, I misunderstood. It should open in the current workspace from the preview. It still doesn't do that.

[onilton]

I am also facing this issue, is it a good first issue/PR? If it his, can someone provide directions on where to start? I am willing to help. :)

[onilton]

Ok, so far I managed to compile, understand some of the patchs, and look a lot at the code. I managed to understand that at

node/server.ts we capture the /webview link.

If I understand correctly I would have to intercept the link and decide if it is an internal or external resouce.

What I am failing to understand is how can I pass this captured info from this code to the editor itself. I see that ?folder and/or ?workspace is stored with writeSettings( but I couldn't find where this info is retrieved in the editor side. I got the feeling this is an existing vscode code, not code-server, but couldn't find it.

I thinking dealing with opening a file maybe similar to this strategy, but since I don't understand it fully yet, couldn't avance further.

Also, I was working in the v2 branch (since I couldn't make the master work withou getting reconnect issues).

[onilton]

Ok, more progress, I found what I want but it seems to no be working as intended:

It seems like WORKBENCH_WEB_CONFIGURATION is being interpolated in browser/workbench.html, and folder info is passed through folderUri: property. The problem is that seems that startPath is never filled (undefined), since this.getFirstValidPath fails with:

ENOENT: no such file or directory, stat '.'/home/myuser/workspace/vscode/src/vs/server/vscode-remote:/127.0.0.1:8080/home/myuser/Downloads/

The issue is that using ?folder= is still working despite that issue, so I don't know HOW it is working 😅

[code-asher]

In v2 we had a bug in some cases when parsing `folder` but it should be fixed in latest master. It probably still works (in v2) because VS Code also looks at the query parameter. That code was removed in v3 though because it conflicted with ours. I'm not sure `server.ts` is where this issue would be fixed. The preview outputs a link but there needs to be some JavaScript that captures the click on the link and opens the file in the workspace instead. I haven't done any digging yet to see exactly what the problem is but it might need to be fixed in the builtin markdown extension itself?

[onilton]

@code-asher I dig into the markdown extension itself, but it seems it just set all relative links to /webview , so that's why I tried to intercept /webview at least for testing.

I couldn't make v3 work. It gave me "please reconnect" errors. That's why I fallback to v2 since it is the docker version (which also worked). Maybe I will try to run v3 to see if the code is easier for me to parse.

What you think? Should I try to go for v3?

[onilton]

Ok, checked out V3 and managed to make it work (I think it was an issue with node version). Got what you said about the folder query parameter handling happening both in code-server and vscode. Found in patch that code-server removed some code about this. I will proceed my investigation. Thanks.