globalState is not persisted across extension updates

[Veetaha]

Our extension fails to work on code-server (rust-lang/rust-analyzer#5892).
The problem is that we use globalState. We expect the contents of globalState to persist across the extension version updates. Even though this is not mentioned in vscode API docs, but original vscode does persist it, but code-server doesn't.

For example we check for new nightly extension release and record it in globalState like this.
But when we programmatically install the extension from VSIX and reload the window, code-server clears the persistent storage.

Meta

• Web Browser: Google Chrome Version 84.0.4147.125 (Official Build) (64-bit)
• Local OS: Ubuntu 20.04.1 LTS
• Remote OS: (idk, just running code-server on my local PC, so probably same as Local OS)
• Remote Architecture: x86_64 my PC
• code-server --version: 3.4.1 48f7c27

[nhooyr]

cc @code-asher

[code-asher]

I can replicate with:

await context.globalState.update("key", "value")
vscode.commands.executeCommand("workbench.action.reloadWindow");

I think that (in the web version of VS Code at least) the storage file isn't written to immediately but rather after a delay and reloading for some reason interrupts that delay causing it to never write (further supported by the fact that adding a 1s timeout around the reload makes it work).

Hopefully will be able to track down why the write gets canceled and get it fixed today.

[Veetaha]

Should we close this?

[code-asher]

Recently we've switched to closing the issues once a release with the fix goes out so let's leave it open for now!

[code-asher]

We recently started using milestones so we can close this now and track whether it's released using the milestone.