[go-migration] Refactoring and code cleanup for Tomcat container and some frameworks#1225
Merged
ramonskie merged 13 commits intocloudfoundry:mainfrom Mar 30, 2026
Merged
[go-migration] Refactoring and code cleanup for Tomcat container and some frameworks#1225ramonskie merged 13 commits intocloudfoundry:mainfrom
ramonskie merged 13 commits intocloudfoundry:mainfrom
Conversation
ramonskie
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor and code cleanup for some components where certain issues and peculiarities appeared with AI generated code, for example:
JBP_CONFIG_TOMCATwas subject of regex parsing instead of proper yaml parsing. No matter the expected format, some custom string configs might achieve it also as long as the regex passes. Proper yaml parsing is now introduced using theyamlHanlderthin wrapper aroundyaml.v3. Some clean code refactorings and tests adjustments are also implemented.yamlHanlderthin wrapper aroundyaml.v3.yamlHanlderthin wrapper aroundyaml.v3. Also introduce some more tests.