Open
Conversation
Refactor _RouteOptions class to handle added options in future
Contributor
Author
|
@Kehrlann Is it necessary something else to be added before code review to be done? |
Kehrlann
requested changes
Apr 7, 2026
|
|
||
| /** | ||
| * The loadbalancing | ||
| * All route options, including unknown future keys. |
Contributor
There was a problem hiding this comment.
That's not a pattern we use anywhere, I don't think we should introduce it unless we have a very good reason to have it for this one specific sub-resource.
Otherwise, let's just add the hashes for now.
Contributor
Author
There was a problem hiding this comment.
The reason why this pattern is used is because the client library doesn't keep up well with all new features introduced in Cloudfoundry API and it's annoying that consumers of cf-java-client library cannot use latest available features until it's contributed and released. So if there is an option to make some logic more generic, I think it's better for all users. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor _RouteOptions class to handle added options in future