Add controller-wide CA certificate bundle support#710
Merged
gabriel-samfira merged 2 commits intocloudbase:mainfrom Apr 10, 2026
Merged
Add controller-wide CA certificate bundle support#710gabriel-samfira merged 2 commits intocloudbase:mainfrom
gabriel-samfira merged 2 commits intocloudbase:mainfrom
Conversation
Add the ability to upload a controller wide CA bundle. While the endpoint bundles are aimed at validating the source forge endpoint certificates, the controller wide CA bundle is meant to encompas the GARM API itself, and any other endpoints user workflows may require. The GARM API may sit behind a self signed CA. Runners need to be able to validate the GARM API when they come online. Overloading the source forge CA bundles to be used to validate GARM itself or other endpoints is undesirable, as we'd need to upload the same CA in all source forges. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Add the controller CA to the windows userdata wrapper, and make sure the linux cloud-init config includes both the endpoint and the controller CA. The idea is to make sure the controller CA is installed before any call to the GARM API is made. This will ensure that the certificate is trusted even when GARM uses a self signed cert. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to configure a CA certificate bundle at the controller level, separate from per-endpoint bundles. The controller CA is combined with endpoint CAs (deduplicated) and installed on runners before any GARM API calls are made. On Linux via cloud-init extra CA certs, and on Windows via the userdata wrapper importing certs into the Root store. This ensures runners can validate GARM's TLS certificate even when it uses a self-signed CA, without needing to duplicate the same bundle across all forge endpoints.
While you can use the controller wide CA bundle to include multiple CAs, it is recommended to keep this bundle to a minimum, as growing the userdata above 16KB may make it fail on providers such as EC2.