fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift#8111
fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift#8111chriscanin wants to merge 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: a434677 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis pull request adds a patch-level fix to the Expo config plugin that changes how ClerkViewFactory.swift is located during iOS AppDelegate injection. The previous multi-location search approach is replaced with a require.resolve-based method that derives the package root from Possibly related issues
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can approve the review once all CodeRabbit's comments are resolved.Enable the |
Summary
possiblePathsarray inwithClerkIOSconfig plugin withrequire.resolve('@clerk/expo/package.json')to locateClerkViewFactory.swiftapps/mobile/)Reported in
Closes #8049
Test plan
expo prebuildin a pnpm workspace with app nested 2+ levels deep and verify no⚠️ ClerkViewFactory.swift not foundwarningexpo prebuildin a standard npm/yarn project and verify it still works🤖 Generated with Claude Code
Summary by CodeRabbit