Slightly simplify lastgenre client

[snejus]

Consolidate Last.fm genre fetching into a single fetch method

This PR simplifies the lastgenre client API by replacing three separate fetch methods (fetch_track_genre, fetch_album_genre, fetch_artist_genre) with a single unified fetch(kind, obj) method.

What changed

client.py:

• Introduces a class-level FETCH_METHODS registry (ClassVar dict) mapping fetch "kinds" ("track", "album", "artist", "album_artist") to a (pylast_method, arg_extractor) tuple.
• Replaces the three fetch_* methods with a single fetch(kind, obj) that dispatches via this registry.
• Removes a private _tags_for wrapper — its logic is inlined into the now-public fetch_genres.
• Drops the workaround for a pylast.Album.get_top_tags() inconsistency fixed in 2014.

__init__.py:

• All call sites updated to use client.fetch(kind, obj) — the client now owns field extraction (e.g. obj.artist, obj.album), removing that concern from the plugin layer.

test_lastgenre.py:

• Test mocking simplified: a single monkeypatch on LastFmClient.fetch replaces three separate method patches.

Impact

• Reduced surface area: one method to mock, test, and reason about instead of three.
• Field extraction centralised: callers no longer need to know which fields to pass per entity type.
• No behaviour change — pure refactor.

[github-actions]

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

[Copilot]

Pull request overview

PR make lastgenre Last.fm client API smaller. Instead of 3 fetch funcs, now one fetch(kind, obj) dispatch table, and plugin call sites updated to use it.

Changes:

• Add LastFmClient.FETCH_METHODS registry and new fetch(kind, obj) dispatcher.
• Inline old tag parsing into fetch_genres and remove old per-entity fetch methods.
• Update plugin + tests to use new fetch API and simpler mocking.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
beetsplug/lastgenre/client.py	Add unified fetch dispatch + simplify tag fetch/filter path
beetsplug/lastgenre/init.py	Switch genre resolution stages to call client.fetch(kind, obj)
test/plugins/test_lastgenre.py	Update tests to new API + monkeypatch LastFmClient.fetch

[codecov]

Codecov Report

❌ Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.56%. Comparing base (72b1118) to head (e0b757c).
⚠️ Report is 6 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
beetsplug/lastgenre/client.py	60.00%	3 Missing and 1 partial ⚠️
beetsplug/lastgenre/__init__.py	57.14%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6495   +/-   ##
=======================================
  Coverage   70.55%   70.56%           
=======================================
  Files         148      148           
  Lines       18820    18812    -8     
  Branches     3066     3065    -1     
=======================================
- Hits        13279    13274    -5     
+ Misses       4894     4891    -3     
  Partials      647      647           

Files with missing lines	Coverage Δ
beetsplug/lastgenre/__init__.py	81.67% <57.14%> (ø)
beetsplug/lastgenre/client.py	53.65% <60.00%> (-1.45%)	⬇️

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[snejus]

@JOJ0 I also added you as the lastgenre codeowner :)

[JOJ0]

@snejus please rebase on master and let's get this in. That's the simplification you mentioned a while ago! Great! Thanks!

[JOJ0]

Thanks a lot! Great simplification! Removed an unused import, now all green. 🎉