fix(queue): prevent usize underflow in frame_queue prune when queue is empty#1751
Open
lavidaloca26 wants to merge 1 commit intobase:mainfrom
Open
fix(queue): prevent usize underflow in frame_queue prune when queue is empty#1751lavidaloca26 wants to merge 1 commit intobase:mainfrom
lavidaloca26 wants to merge 1 commit intobase:mainfrom
Conversation
Collaborator
🟡 Heimdall Review Status
|
|
Someone is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The FrameQueue::prune() function has an off-by-one error that causes a usize underflow panic. When the queue has fewer than 2 elements, the expression
self.queue.len() - 1underflows because usize is unsigned in Rust.Fix
Added an early return check
if self.queue.len() < 2 { return; }before the while loop to prevent the underflow. This is safe because the pruning logic requires at least 2 frames to compare.Why change is safe