fix(data_classes): support {proxy+} and path parameters in authorizer response#8092
Open
leandrodamascena wants to merge 1 commit intodevelopfrom
Open
fix(data_classes): support {proxy+} and path parameters in authorizer response#8092leandrodamascena wants to merge 1 commit intodevelopfrom
leandrodamascena wants to merge 1 commit intodevelopfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8092 +/- ##
========================================
Coverage 96.63% 96.63%
========================================
Files 283 283
Lines 13862 13862
Branches 1111 1111
========================================
Hits 13395 13395
Misses 342 342
Partials 125 125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: closes #7979
Summary
The
path_regexinAPIGatewayAuthorizerResponsewas rejecting valid API Gateway resource paths that contain{,}, and+characters (e.g./{proxy+},/users/{user_id}).Changes
Updated the regex from
^[/.a-zA-Z0-9-_\*]+$to^[/.a-zA-Z0-9\-_\*\{\}\+]+$.User experience
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.