Skip to content

Basic !!should functionality added#1

Open
mega6382 wants to merge 1 commit intoasync-bot:masterfrom
mega6382:master
Open

Basic !!should functionality added#1
mega6382 wants to merge 1 commit intoasync-bot:masterfrom
mega6382:master

Conversation

@mega6382
Copy link
Copy Markdown

No description provided.

{
$this->choice = $choice;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra newline

{
$this->reply = $reply;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra newline

Comment thread src/Plugin.php
{
return (new ShouldIHandler())->should($choice1, $choice2);
}
/**
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline and remove docblock

Comment thread src/Plugin.php

final class Plugin
{
/**
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove docblock

Comment thread src/Plugin.php
namespace AsyncBot\Plugin\ShouldI;
use AsyncBot\Plugin\ShouldI\ValueObject\Result\ShouldI;
use AsyncBot\Plugin\ShouldI\ValueObject\Result\Is;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these two newlines

return 'banana';
}, $text);
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove newline


return new ShouldI($answer);
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra newline

private function translatePronouns(string $text): string
{
static $replacePairs = [
'iyou' => ['i', 'you'],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align all ze =>

{
public function should(string $choice1, string $choice2): ShouldI
{
$yes = $choice1;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align equals signs

Comment thread src/Handler/IsHandler.php
{
return self::RESPONSES[$answer][random_int(0, (count(self::RESPONSES[$answer]) - 1))];
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove newline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants