[TEST][CODEGEN] Fix the test scripts tries to tell numpy a dtype name that it cannot recognise#18430
Merged
tlopex merged 2 commits intoapache:mainfrom Nov 11, 2025
Merged
Conversation
… it cannot recognise
7943bfe to
ea19457
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is trying to fix issues #18394. The root cause was that NumPy doesn't natively understand the
float4_e2m1fndtype. Theml_dtypespackage provides NumPy-compatible implementations of these custom dtypes. By importing the actual dtype object fromml_dtypesinstead of using a string, NumPy can properly create arrays with the correct dtype.