[LLVM][RUNTIME] Make ORCJIT LLVM executor the default one#17538
Merged
tqchen merged 1 commit intoapache:mainfrom Nov 26, 2024
Merged
[LLVM][RUNTIME] Make ORCJIT LLVM executor the default one#17538tqchen merged 1 commit intoapache:mainfrom
tqchen merged 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
This is ready for review. |
Member
|
@cbalint13 can you dig a bit into windows issue? seems related to a missing symbol |
Contributor
Author
@tqchen , Yes I am on it, it will take a little bit of time. |
534999c to
5b83fdc
Compare
5b83fdc to
7a09ef6
Compare
Contributor
Author
|
@tqchen ,
If this goes to main will help track & tackle issues as they arise, I hope for the best that there will be none at all. |
Contributor
Author
|
@tvm-bot rerun |
tqchen
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR propose to make ORCJIT the default LLVM runtime executor (engine).
Notes
llvm -jit=orcjitflag, introduced here.TVM disscussions and recent issues on the subject:
Since ORCJIT was poorly exposed within TVM until now (being optional) any rising issues will need attention.