Compiled with Default Target(LLVM) and Built with USE_MRVL=ON#17455
Merged
leandron merged 14 commits intoapache:mainfrom Oct 25, 2024
Merged
Compiled with Default Target(LLVM) and Built with USE_MRVL=ON#17455leandron merged 14 commits intoapache:mainfrom
leandron merged 14 commits intoapache:mainfrom
Conversation
added 8 commits
October 9, 2024 13:09
… BYOC(apache#17454) It is a unique use-case to check the default target(LLVM), though TVM is built with BYOC(MRVL-ON) The config of Codegen(BYOC) contains default values for configuration/options, it is extracted during _generate_codegen_args. In command line processing, validate_target_args checks if there are add-on options and it expects that particular target to be given explicitly in command line. Here, it is test for default (LLVM) path only, hence validate_target_args need to ignore the codegen's configuration for default target. Signed-off-by: M N Ganesan <muthusamynam@marvell.com>
… BYOC(apache#17454) It is a unique use-case to check the default target(LLVM), though TVM is built with BYOC(MRVL-ON) The config of Codegen(BYOC) contains default values for configuration/options, it is extracted during _generate_codegen_args. In command line processing, validate_target_args checks if there are add-on options and it expects that particular target to be given explicitly in command line. Here, it is test for default (LLVM) path only, hence validate_target_args need to ignore the codegen's configuration for default target. Signed-off-by: M N Ganesan <muthusamynam@marvell.com>
… BYOC(apache#17454) It is a unique use-case to check the default target(LLVM), though TVM is built with BYOC(MRVL-ON) The config of Codegen(BYOC) contains default values for configuration/optons, it is extracted during _generate_codegen_args. In command line processing, validate_target_args checks if there are add-on options and it expects that particular target to be given explicitly in command line. Here, it is test for default (LLVM) path only, hence validate_target_args need to ignore the codegen's configuration
… BYOC(apache#17454) It is a unique use-case to check the default target(LLVM), though TVM is built with BYOC(MRVL-ON) The config of Codegen(BYOC) contains default values for configuration/optons, it is extracted during _generate_codegen_args. In command line processing, validate_target_args checks if there are add-on options and it expects that particular target to be given explicitly in command line. Here, it is test for default (LLVM) path only, hence validate_target_args need to ignore the codegen's configuration
…o default_target
…h BYOC(apache#17454) It is a unique use-case to check the default target(LLVM), though TVM is built with BYOC(MRVL-ON) The config of Codegen(BYOC) contains default values for configuration/optons, it is extracted during _generate_codegen_args. In command line processing, validate_target_args checks if there are add-on options and it expects that particular target to be given explicitly in command line. Here, it is test for default (LLVM) path only, hence validate_target_args need to ignore the codegen's configuration Signed-off-by: M N Ganesan <muthusamynam@marvell.com>
…h BYOC(apache#17454) It is a unique use-case to check the default target(LLVM), though TVM is built with BYOC(MRVL-ON) The config of Codegen(BYOC) contains default values for configuration/optons, it is extracted during _generate_codegen_args. In command line processing, validate_target_args checks if there are add-on options and it expects that particular target to be given explicitly in command line. Here, it is test for default (LLVM) path only, hence validate_target_args need to ignore the codegen's configuration Signed-off-by: M N Ganesan <muthusamynam@marvell.com>
…h BYOC(apache#17454) It is a unique use-case to check the default target(LLVM), though TVM is built with BYOC(MRVL-ON) The config of Codegen(BYOC) contains default values for configuration/optons, it is extracted during _generate_codegen_args. In command line processing, validate_target_args checks if there are add-on options and it expects that particular target to be given explicitly in command line. Here, it is test for default (LLVM) path only, hence validate_target_args need to ignore the codegen's configuration Signed-off-by: M N Ganesan <muthusamynam@marvell.com>
Contributor
Author
Member
|
cc TVMC maintainer @leandron |
leandron
requested changes
Oct 17, 2024
…_MRVL=ON(apache#17454) This is a use-case of invoking TVMC with default target though it is built with MRVL_ON. In command line processing, validate_target_args checks if there are add-on options derived from the default arguments of codegen/BYOC and it expects that particular codegen to be given explicitly in command line. However, certain codegen's can have default target alone, in that case codegen optios are not extracted there by relaxing the validation Signed-off-by: M N Ganesan <muthusamynam@marvell.com>
Contributor
Author
|
Please review my updated patch which has generic fix., Eg: Thanks |
added 4 commits
October 24, 2024 09:28
…o default_target
…_MRVL=ON(apache#17454) This is a use-case of invoking TVMC with default target though it is built with MRVL_ON. In command line processing, validate_target_args checks if there are add-on options derived from the default arguments of codegen/BYOC and it expects that particular codegen to be given explicitly in command line. However, certain codegen's can have default target alone, in that case codegen optios are not extracted there by relaxing the validation Signed-off-by: M N Ganesan <muthusamynam@marvell.com>
…o default_target
…E_MRVL=ON(apache#17454) This is a use-case of invoking TVMC with default target though it is built with MRVL_ON. In command line processing, validate_target_args checks if there are add-on options derived from the default arguments of codegen/BYOC and it expects that particular codegen to be given explicitly in command line. However, certain codegen's can have default target alone, in that case codegen optios are not extracted there by relaxing the validation Signed-off-by: M N Ganesan <muthusamynam@marvell.com>
leandron
approved these changes
Oct 24, 2024
Contributor
leandron
left a comment
There was a problem hiding this comment.
OK, thanks, it looks very elegant and general now.
Contributor
Author
|
Could you please merge this PR? Thanks |
Contributor
Yes, I just forgot this step after the review. This is merged now - thanks for your PR. |
Contributor
Author
|
Thanks a lot for your quick review feedback and response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the fix:
It is a unique use-case to check the default target(LLVM), though TVM is built with BYOC(MRVL-ON)
The config of Codegen(BYOC) contains default values for configuration/optons, it is extracted
during _generate_codegen_args. In command line processing, validate_target_args checks if there are add-on options and it expects that particular target to be given explicitly in command line. Here, it is test for default (LLVM) path only, hence validate_target_args need to ignore the codegen's configuration