[Fix][TIR] Fix outdated call to create extern buffer in make_extern#17138
Merged
vinx13 merged 1 commit intoapache:mainfrom Jul 10, 2024
Merged
[Fix][TIR] Fix outdated call to create extern buffer in make_extern#17138vinx13 merged 1 commit intoapache:mainfrom
vinx13 merged 1 commit intoapache:mainfrom
Conversation
vinx13
approved these changes
Jul 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C++ implementation of
make_externcalls a local function(DeclExternBuffer) which is outdated and doesn't do the same thing as the equivalent Python function.The Python implementation of
decl_bufferwas changed in #6317 and a check was added inbuffer.ccwhich fails if you try to usemake_externin C++.This PR fixes this by calling the
tvm::tir::decl_bufferfunction in C++ which does the same thing as the Python implementation.