[Relay] Expose qnn ops directly from relay.qnn module#15928
Merged
quic-sanirudh merged 3 commits intoapache:mainfrom Oct 17, 2023
Merged
[Relay] Expose qnn ops directly from relay.qnn module#15928quic-sanirudh merged 3 commits intoapache:mainfrom
quic-sanirudh merged 3 commits intoapache:mainfrom
Conversation
When we access `nn` ops in relay, we can directly access them as `relay.nn.<op>` where `<op>` can be any nn op like `conv2d`, `avg_pool2d`, etc. When we access `qnn` ops, we need to access them as `relay.qnn.op.<op>` as they're not exposed to the `relay.qnn` module. This change tries to add that.
de42965 to
82f23c5
Compare
Contributor
Author
|
cc @ibsidorenko |
ibsidorenko
approved these changes
Oct 16, 2023
Contributor
|
LGTM. Do you plan to change access names in unit tests? |
Contributor
Author
Thanks for the review, and yes, I'll update the tests and push it today. Initially I thought it might introduce a lot of changes that hurts git history un-necessarily, but now I think there could be some advantage to doing it (especially since tests are seen as an initial source of example usage of an API). |
kparzysz-quic
approved these changes
Oct 16, 2023
Contributor
kparzysz-quic
left a comment
There was a problem hiding this comment.
LGTM. Thanks @quic-sanirudh!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we access
nnops in relay, we can directly access them asrelay.nn.<op>where<op>can be any nn op likeconv2d,avg_pool2d, etc.When we access
qnnops, we need to access them asrelay.qnn.op.<op>as they're not exposed to therelay.qnnmodule. This change tries to add that.