[Arith] Fix handling of overlapping predicates#15555
Merged
quic-sanirudh merged 1 commit intoapache:mainfrom Aug 16, 2023
Merged
[Arith] Fix handling of overlapping predicates#15555quic-sanirudh merged 1 commit intoapache:mainfrom
quic-sanirudh merged 1 commit intoapache:mainfrom
Conversation
When the lower bound predicate is present, `TryFuseIters` will rewrite an expression to `IterMarkWithOffset`, where the iter mark (structured form) has minimum value of zero. During rewriting, when the subexpression matches a previous rewritten result (`IterMarkWithOffset`), previously it doesn't correctly add the offset to the result `IterMarkWithOffset`, and causes inconsistency between the flattened form and the structured (normal) form.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
wrongtest-intellif
approved these changes
Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the lower bound predicate is present,
TryFuseIterswill rewrite an expression toIterMarkWithOffset, where the iter mark (structured form) has minimum value of zero. During rewriting, when the subexpression matches a previous rewritten result (IterMarkWithOffset), previously it doesn't correctly add the offset to the resultIterMarkWithOffset, and causes inconsistency between the flattened form and the structured (normal) form.cc @wrongtest-intellif @spectrometerHBH