[SPARK-54892] Support list data type#272
Closed
dongjoon-hyun wants to merge 2 commits intoapache:mainfrom
Closed
Conversation
viirya
reviewed
Jan 4, 2026
Comment on lines
413
to
+430
| case ArrowTypeId.string: | ||
| return "u" | ||
|
|
||
| if let structType = self as? ArrowTypeStruct { |
Member
There was a problem hiding this comment.
I wonder why this if let structType = self as? ArrowTypeStruct { is after above return "u" for string type? Shouldn't there be case ArrowTypeId.struct:?
Member
Author
There was a problem hiding this comment.
Oops. My bad. I missed case ArrowTypeId.strct: here while sycing. Thank you, @viirya .
viirya
approved these changes
Jan 4, 2026
Member
Author
|
Thank you, @viirya . |
Member
Author
|
Merged to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to support
listdata type by syncing with Apache Arrow Swift project.Why are the changes needed?
We still cannot use Apache Arrow Swift directly due to the mismatch like apache/arrow#46628. Until we achieve the goal, we need to sync with the upstream to bring newly added but unreleased features.
list(Array) type arrow-swift#16Does this PR introduce any user-facing change?
No,
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.