Skip to content

[IOTDB-14788][Docker] Add REST API port to Docker Compose example#17244

Open
ShauryaChauhan1411 wants to merge 2 commits intoapache:masterfrom
ShauryaChauhan1411:docs/iotdb-14788-docker-rest-port
Open

[IOTDB-14788][Docker] Add REST API port to Docker Compose example#17244
ShauryaChauhan1411 wants to merge 2 commits intoapache:masterfrom
ShauryaChauhan1411:docs/iotdb-14788-docker-rest-port

Conversation

@ShauryaChauhan1411
Copy link
Contributor

Fixes #14788

Description
Added port 18080 and enable_rest_service=true to the Docker Compose standalone configuration to allow REST API access by default.

Note
I searched for the Rest-Service.md documentation files but they do not appear to be present in the root of the current master branch.

CC: @CritasWang @HTHou

@ShauryaChauhan1411
Copy link
Contributor Author

Hi @CritasWang, @HTHou. It seems the Cluster IT / Simple (17) check failed due to a SUBSTRING function error and type validation issues. Since my changes are strictly limited to the docker-compose-standalone.yml file, these failures appear to be unrelated to my PR.

Could you please trigger a re-run of the failing checks?

@ShauryaChauhan1411
Copy link
Contributor Author

Hi @CritasWang @HTHou Gentle follow-up on this PR.

I noticed the Cluster IT - 1C3D / Simple (17) check is failing, but after checking the logs, it seems to be a SUBSTRING function error which appears unrelated to my changes in docker-compose-standalone.yml.

Could you please trigger a re-run of the failing checks? If they still fail, I'd be happy to help investigate if it's a flaky test in the current master branch. Thanks!

@JackieTien97
Copy link
Contributor

hi @ShauryaChauhan1411, I think the default configuration of docker should be same as the distribution package, so I think it will be better not to change that

@JackieTien97
Copy link
Contributor

And BTW, if you want to change the default conf for some envs, it's better for you to firstly have a discussion in the dev mail list.

@ShauryaChauhan1411
Copy link
Contributor Author

Thanks for the feedback, @JackieTien97 . I see your point about maintaining consistency with the distribution package. I'll revert the default port changes in this PR to match the standard config. I'll also start a thread on the dev mailing list to see if the community thinks there's a better way to handle REST API visibility for Docker users without breaking that consistency.

Reverted the REST service port mapping and environment variable to ensure the Docker configuration remains consistent with the distribution package.
@ShauryaChauhan1411
Copy link
Contributor Author

Hi @JackieTien97 , I've reverted the changes in docker-compose-standalone.yml to match the distribution package defaults.

Regarding the REST API visibility for specific environments, I'll follow your advice and start a discussion thread on the dev mailing list to see how the community prefers to handle this. Thanks for the guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOCUMENTATION] port settings for REST api in docker compose file.

2 participants