Skip to content

Pipe: Fixed the OPC UA client connection problem#17083

Merged
jt2594838 merged 2 commits intomasterfrom
opc-many-fix
Jan 28, 2026
Merged

Pipe: Fixed the OPC UA client connection problem#17083
jt2594838 merged 2 commits intomasterfrom
opc-many-fix

Conversation

@Caideyipi
Copy link
Copy Markdown
Collaborator

@Caideyipi Caideyipi commented Jan 26, 2026

Description

The OPC clients may flood to the receiver when there are multiple regions. However, the OPC Server has rates limit and will reject client connections if they're too often. Thus, I:

  1. Reused the client pointing to the same receiver on the same dataNode.
  2. Set retry seconds and will keep retry per second for rate limit at server.

This PR has:

  • been self-reviewed.
    • concurrent read
    • concurrent write
    • concurrent read and write
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods.
  • added or updated version, license, or notice information
  • added comments explaining the "why" and the intent of the code wherever would not be obvious
    for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold
    for code coverage.
  • added integration tests.
  • been tested in a test IoTDB cluster.

Key changed/added classes (or packages if there are too many classes) in this PR

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
5.4% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 5.12821% with 74 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.07%. Comparing base (d9c3fc9) to head (87e3a84).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...e/iotdb/db/pipe/sink/protocol/opcua/OpcUaSink.java 12.50% 28 Missing ⚠️
.../pipe/sink/protocol/opcua/client/ClientRunner.java 0.00% 23 Missing ⚠️
...e/sink/protocol/opcua/client/IoTDBOpcUaClient.java 0.00% 14 Missing ⚠️
...ion/config/executor/ClusterConfigTaskExecutor.java 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #17083   +/-   ##
=========================================
  Coverage     39.06%   39.07%           
  Complexity      282      282           
=========================================
  Files          5126     5126           
  Lines        343001   343053   +52     
  Branches      43746    43751    +5     
=========================================
+ Hits         134010   134033   +23     
- Misses       208991   209020   +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jt2594838 jt2594838 merged commit 82f7ca6 into master Jan 28, 2026
30 of 31 checks passed
@jt2594838 jt2594838 deleted the opc-many-fix branch January 28, 2026 02:16
Caideyipi added a commit that referenced this pull request Mar 26, 2026
Caideyipi added a commit that referenced this pull request Mar 26, 2026
…hanged the default value of the server security policies & Made the default quality configurable and does not throw when non-value/quality measurement is encountered (#16944)

fix

Pipe: Fixed the OPC UA client connection problem (#17083)

* fix

* IT

(cherry picked from commit 82f7ca6)

spt

Optimized the logger when table does not exist in DN heartbeat && Pipe: Fixed the OPC UA Sink key getter logic and potentail NPE when closing client && Load: Fixed the missing schema writing for "root" table (#17063)

* root-fix

* f

* fix

* rest

* spls

* gsa

* fix

(cherry picked from commit 5101489)

fix

Pipe: Implemented OPC Sink for outer server & Set configuration and changed the default value of the server security policies & Made the default quality configurable and does not throw when non-value/quality measurement is encountered (#16944)

* pj

* cj

* bone

* fix

* fix

* framework

* fix

* trilog

* framework

* fix

* fix

* yl

* stack-client

* fix

* might

* sleep-removal

* cleaning

* fix

* sec-dir

* cleaning

* remove-poison

* f

* fix

* clean-sit

* sit-comp

* object

* many-clean

* sit-sit

* fix

* fix

* fix

* ref

* sit

* partial

* security-policies

* check-equals

* check-err

* fix

* compile-fix

* adjust

* ut

* refactor

* fix_and_IT

* fix

* placeholder

* rollback

* eliminate-fault

* pw

* fix

* f

* fix

(cherry picked from commit cb18a95)
jt2594838 pushed a commit that referenced this pull request Mar 27, 2026
…hanged the default value of the server security policies & Made the default quality configurable and does not throw when non-value/quality measurement is encountered (#16944) (#17367)

fix

Pipe: Fixed the OPC UA client connection problem (#17083)

* fix

* IT

(cherry picked from commit 82f7ca6)

spt

Optimized the logger when table does not exist in DN heartbeat && Pipe: Fixed the OPC UA Sink key getter logic and potentail NPE when closing client && Load: Fixed the missing schema writing for "root" table (#17063)

* root-fix

* f

* fix

* rest

* spls

* gsa

* fix

(cherry picked from commit 5101489)

fix

Pipe: Implemented OPC Sink for outer server & Set configuration and changed the default value of the server security policies & Made the default quality configurable and does not throw when non-value/quality measurement is encountered (#16944)

* pj

* cj

* bone

* fix

* fix

* framework

* fix

* trilog

* framework

* fix

* fix

* yl

* stack-client

* fix

* might

* sleep-removal

* cleaning

* fix

* sec-dir

* cleaning

* remove-poison

* f

* fix

* clean-sit

* sit-comp

* object

* many-clean

* sit-sit

* fix

* fix

* fix

* ref

* sit

* partial

* security-policies

* check-equals

* check-err

* fix

* compile-fix

* adjust

* ut

* refactor

* fix_and_IT

* fix

* placeholder

* rollback

* eliminate-fault

* pw

* fix

* f

* fix

(cherry picked from commit cb18a95)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants