Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Add 2 new Make command (
make notebook) to spin up a jupyter notebook;make notebook-infraspins up jupyter notebook along with integration test infrastructure.Pyiceberg Example Notebook
Pyiceberg example notebook (
notebooks/pyiceberg_example.ipynb) is based on the https://py.iceberg.apache.org/#getting-started-with-pyiceberg page and doesn't require additional test infra.Spark Example Notebook
Spark integration example notebook (
notebooks/spark_integration_example.ipynb) is based on https://iceberg.apache.org/docs/nightly/spark-getting-started/ and requires integration test infrastructure (Spark, IRC, S3)With spark connect (#2491) and our testing setup, we can quickly spin up a local env with
make test-integration-execwhich includes:In the jupyter notebook, connect to spark easily
Are these changes tested?
Yes, run both
make notebookandmake notebook-infralocally and run the example notebooksAre there any user-facing changes?