Conversation
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4169 |
yadvr
left a comment
There was a problem hiding this comment.
LGTM (but hey this only fixes if someone upgrades to 4.17.1.0 or 4.18.0.0++, it may break still for 4.17.0.1, 4.17.0.0 releases)
| ALTER TABLE `cloud`.`event` | ||
| ADD COLUMN `resource_id` bigint unsigned COMMENT 'ID of the resource associated with the event' AFTER `domain_id`, | ||
| ADD COLUMN `resource_type` varchar(32) COMMENT 'Type of the resource associated with the event' AFTER `resource_id`; | ||
| CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.event','resource_id', 'bigint unsigned COMMENT "ID of the resource associated with the event" AFTER `domain_id`'); |
There was a problem hiding this comment.
@DaanHoogland is this IDEMPOTENT_ADD_COLUMN method declared in this sql ?
There was a problem hiding this comment.
sure, but also it should already be present in the server. We have re-defined it in several upgrade steps.
|
@blueorangutan test |
|
@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
Codecov Report
@@ Coverage Diff @@
## 4.17 #6728 +/- ##
=========================================
Coverage 5.88% 5.88%
Complexity 3927 3927
=========================================
Files 2451 2451
Lines 242338 242338
Branches 37923 37923
=========================================
Hits 14261 14261
Misses 226502 226502
Partials 1575 1575 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
borisstoyanov
left a comment
There was a problem hiding this comment.
LGTM, just upgraded this manually and it's working fine
|
Trillian test result (tid-4870)
|
Description
This PR tries to fix a problem with a privately backported feature. The columns added for the feature are not added idem potent so people can not backport them. I propose that all DB alteration from here on in will be done with the
IDEM_POTENT_...()set of stored procedures that we have to prevent these kind of issues for users.So far this has only been done with one feature but I propose to regirously do this for all code.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?