Skip to content

UI fix Theme text color not bind navTextColorPick and reset button#6721

Merged
shwstppr merged 6 commits intoapache:4.17from
hooklee2000:4.17
Sep 14, 2022
Merged

UI fix Theme text color not bind navTextColorPick and reset button#6721
shwstppr merged 6 commits intoapache:4.17from
hooklee2000:4.17

Conversation

@hooklee2000
Copy link
Copy Markdown
Contributor

UI fix Theme text color not bind navTextColorPick fix #6720

@acs-robot
Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6721 (SL-JID-2327)

Copy link
Copy Markdown

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @hooklee2000

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 9, 2022

Codecov Report

Merging #6721 (669822c) into 4.17 (d3bfdac) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               4.17    #6721   +/-   ##
=========================================
  Coverage      5.88%    5.88%           
- Complexity     3927     3929    +2     
=========================================
  Files          2451     2451           
  Lines        242338   242338           
  Branches      37923    37923           
=========================================
+ Hits          14261    14265    +4     
+ Misses       226502   226498    -4     
  Partials       1575     1575           
Impacted Files Coverage Δ
...apache/cloudstack/syslog/AlertsSyslogAppender.java 58.75% <0.00%> (+2.25%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hooklee2000 hooklee2000 changed the title UI fix Theme text color not bind navTextColorPick and rest button UI fix Theme text color not bind navTextColorPick and reset button Sep 9, 2022
Copy link
Copy Markdown
Contributor

@GutoVeronezi GutoVeronezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@yadvr yadvr modified the milestone: 4.17.1.0 Sep 14, 2022
@shwstppr shwstppr added this to the 4.17.1.0 milestone Sep 14, 2022
@shwstppr shwstppr merged commit c3d6f42 into apache:4.17 Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants