Skip to content

vmware,cks: fix attachiso failure with vmware drs#6625

Merged
yadvr merged 1 commit intoapache:4.17from
shapeblue:fix-vmw-attachiso-drs
Aug 16, 2022
Merged

vmware,cks: fix attachiso failure with vmware drs#6625
yadvr merged 1 commit intoapache:4.17from
shapeblue:fix-vmw-attachiso-drs

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Aug 10, 2022

Description

Fixes #4314

Failure in attaching k8s ISO is seen when VMware DRS is enabled. Log reported VM is not found. This fix tries to find VM on peer hosts when the VM is not found on the given host.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@shwstppr
vmware,cks: fix attachiso failure with vmware drs
97ed948 
Fixes apache#4314

Failure in attaching k8s ISO is seen when VMware DRS is enabled. Log reported VM is not found. This fix tries to find VM on peer hosts when the VM is not found on the given host.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr added this to the 4.17.1.0 milestone Aug 10, 2022
@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Aug 10, 2022

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 10, 2022

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@shwstppr shwstppr linked an issue Aug 10, 2022 that may be closed by this pull request
Failed to attach binaries ISO for VM when create kubernetes cluster #4314
Closed
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 10, 2022

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3958

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Aug 12, 2022

@blueorangutan test centos7 vmware-65u2

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 12, 2022

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 12, 2022

Trillian test result (tid-4674)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43065 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6625-t4674-vmware-65u2.zip
Smoke tests completed. 100 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 908.18 test_kubernetes_clusters.py

DaanHoogland
DaanHoogland approved these changes Aug 15, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@shwstppr shwstppr marked this pull request as ready for review August 16, 2022 07:03
@yadvr yadvr merged commit 770df60 into apache:4.17 Aug 16, 2022
@yadvr yadvr mentioned this pull request Aug 16, 2022
Closed
neogismm pushed a commit to neogismm/cloudstack that referenced this pull request Sep 5, 2022
@shwstppr @neogismm
vmware,cks: fix attachiso failure with vmware drs (apache#6625)
55c7c60 
Fixes apache#4314

Failure in attaching k8s ISO is seen when VMware DRS is enabled. Log reported VM is not found. This fix tries to find VM on peer hosts when the VM is not found on the given host.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@davidjumani davidjumani Awaiting requested review from davidjumani

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

Assignees

No one assigned

Labels

component:vmware

Projects

None yet

Milestone

4.17.1.0

Development

Successfully merging this pull request may close these issues.

Failed to attach binaries ISO for VM when create kubernetes cluster

4 participants

@shwstppr @blueorangutan @yadvr @DaanHoogland