Skip to content

ui: fix deploy vm override custom disk offering#6586

Merged
yadvr merged 1 commit intoapache:4.17from
shapeblue:fix-deployvm-override-root
Jul 29, 2022
Merged

ui: fix deploy vm override custom disk offering#6586
yadvr merged 1 commit intoapache:4.17from
shapeblue:fix-deployvm-override-root

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Jul 29, 2022

Description

Fixes #6585

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@acs-robot
Copy link
Copy Markdown

acs-robot commented Jul 29, 2022

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@shwstppr shwstppr added this to the 4.17.1.0 milestone Jul 29, 2022
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 29, 2022

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 29, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6586 (SL-JID-2029)

@shwstppr
ui: fix deploy vm override custom disk offering
ccdcf5b 
Fixes apache#6585

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr force-pushed the fix-deployvm-override-root branch from 5422f14 to ccdcf5b Compare July 29, 2022 09:11
@acs-robot
Copy link
Copy Markdown

acs-robot commented Jul 29, 2022

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 29, 2022

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 29, 2022

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6586 (SL-JID-2030)

@shwstppr shwstppr marked this pull request as ready for review July 29, 2022 09:20
sureshanaparti
sureshanaparti approved these changes Jul 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@yadvr yadvr merged commit 2a37897 into apache:4.17 Jul 29, 2022
@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Jul 29, 2022

verified OK

neogismm pushed a commit to neogismm/cloudstack that referenced this pull request Aug 6, 2022
@shwstppr @neogismm
ui: fix deploy vm override custom disk offering (apache#6586)
67b998a 
Fixes apache#6585

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr mentioned this pull request Aug 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.17.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@shwstppr @acs-robot @blueorangutan @weizhouapache @yadvr @sureshanaparti