Skip to content

Added reload4j dependency in the pom.xml in storpool#6560

Closed
harikrishna-patnala wants to merge 1 commit intoapache:4.17from
shapeblue:FixBuildFailureWithStorePool
Closed

Added reload4j dependency in the pom.xml in storpool#6560
harikrishna-patnala wants to merge 1 commit intoapache:4.17from
shapeblue:FixBuildFailureWithStorePool

Conversation

@harikrishna-patnala
Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala commented Jul 20, 2022

Description

There are build failures happening on the few PRs with 4.17 branch with below error

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 12:33 min
[INFO] Finished at: 2022-07-20T06:33:31Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project cloud-plugin-storage-volume-storpool: Compilation failure: Compilation failure:
[ERROR] /jenkins/workspace/acs-centos8-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.17.1.0-SNAPSHOT/plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/util/StorPoolHelper.java:[188,21] error: cannot find symbol
[ERROR] symbol: method setConversionPattern(String)
[ERROR] location: variable patternLayout of type PatternLayout
[ERROR] /jenkins/workspace/acs-centos8-pkg-builder/dist/rpmbuild/BUILD/cloudstack-4.17.1.0-SNAPSHOT/plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/util/StorPoolHelper.java:[193,23] error: incompatible types: RollingFileAppender cannot be converted to Appender
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.

Added reload4j dependency in the storpool pom.xml

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

mvn build is successful

@harikrishna-patnala
Copy link
Copy Markdown
Member Author

@blueorangutan package

Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought my recent commit did that, but LGTM

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jul 20, 2022

Thanks @harikrishna-patnala - sorry my bad, I caused this while merging 4.17.0.1 to 4.17 branch somehow the commits got missing (had no effect on fwd-merging which is perhaps because I used the -X ours flag :( )

@yadvr yadvr closed this Jul 20, 2022
@yadvr yadvr deleted the FixBuildFailureWithStorePool branch July 20, 2022 10:50
@github-actions
Copy link
Copy Markdown

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants