vmware,storage: fix solidfire ROOT volume creation with vmware 6.5 and above#6548
vmware,storage: fix solidfire ROOT volume creation with vmware 6.5 and above#6548shwstppr wants to merge 4 commits intoapache:4.17from
Conversation
…toreMO.java Co-authored-by: Daniel Augusto Veronezi Salvador <38945620+GutoVeronezi@users.noreply.github.com>
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
| if (info != null && info.size() > 0) { | ||
| s_logger.info("File " + fileFullPath + " exists on datastore"); | ||
| return true; | ||
| Boolean folderExists = true; |
There was a problem hiding this comment.
is this true by default?
| s_logger.info("File " + fileFullPath + " exists on datastore"); | ||
| return true; | ||
| Boolean folderExists = true; | ||
| if(StringUtils.isNotBlank(file.getDir())){ |
There was a problem hiding this comment.
| if(StringUtils.isNotBlank(file.getDir())){ | |
| if (StringUtils.isNotBlank(file.getDir())) { |
| if(StringUtils.isNotBlank(file.getDir())){ | ||
| folderExists = folderExists(String.format("[%s]", file.getDatastoreName()), file.getDir()); | ||
| } | ||
| if (folderExists){ |
There was a problem hiding this comment.
| if (folderExists){ | |
| if (folderExists) { |
|
|
||
| private void removeVmfsDatastore(Command cmd, VmwareHypervisorHost hyperHost, String datastoreName, String storageIpAddress, int storagePortNumber, | ||
| String iqn, List<Pair<ManagedObjectReference, String>> lstHosts) throws Exception { | ||
| if (HypervisorHostHelper.isHostVersionEqualOrHigher(hyperHost, "6.5")) { |
There was a problem hiding this comment.
does this consider minor release version as well?
|
Hi all, I have some news regarding this PR. I just did some tests using ACS 4.16.1, Solidfire Demo Node with Element OS v.12.5.0.897 and VMware 6.7 My last failed attempt was using ACS 4.16.0, Solidfire Demo Node with Element OS v.12.3.x.x and VMware 6.7 |
|
cc @harikrishna-patnala was any work done towards general storage work that could have fixed the issues with solidfire (as a side effect)? |
|
Based on the comments ^^, I'm closing this for now. Will re-open if later needed. cc @rohityadavcloud @pdion891 |
@tsinik-dw Do you use cloudstack with solidfire storage in your production ? have you faced any issues ? |
Description
Fixes #3598
Continue #4977
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?