Fix issue with configdrive on XenServer

[Pearl1594]

Description

This PR fixes issue: #10318 where in the config drive ISO isn't attached to the VM.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

After fix, we see the configdrive iso present:

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 18.02%. Comparing base (6e19c07) to head (6a9218b).
Report is 2 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...rce/wrapper/xenbase/CitrixStartCommandWrapper.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##               4.19   #10912       +/-   ##
=============================================
+ Coverage     15.17%   18.02%    +2.84%     
- Complexity    11349    16479     +5130     
=============================================
  Files          5416     5738      +322     
  Lines        475621   633948   +158327     
  Branches      58054   101513    +43459     
=============================================
+ Hits          72168   114239    +42071     
- Misses       395380   508348   +112968     
- Partials       8073    11361     +3288     

Flag	Coverage Δ
uitests	4.60% <ø> (+0.32%)	⬆️
unittests	18.86% <0.00%> (+2.96%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13496

[yadvr]

Added tentative milestone & label, if it's a high priority issue - pl check / change as necessary @Pearl1594 @DaanHoogland

[weizhouapache]

@blueorangutan test ol8 xcpng82

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng82) has been kicked to run smoke tests

[DaanHoogland]

clgtm

[blueorangutan]

[SF] Trillian test result (tid-13394)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 110102 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10912-t13394-xcpng82.zip
Smoke tests completed. 126 look OK, 15 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_prepare_and_cancel_maintenance	Error	0.15	test_ms_maintenance_and_safe_shutdown.py
test_nic_secondaryip_add_remove	Error	1518.69	test_multipleips_per_nic.py
ContextSuite context=TestPortForwardingRules>:setup	Error	0.00	test_portforwardingrules.py
ContextSuite context=TestNestedVirtualization>:setup	Error	0.00	test_nested_virtualization.py
ContextSuite context=TestNetworkACL>:setup	Error	0.00	test_network_acl.py
ContextSuite context=TestIpv6Network>:setup	Error	0.00	test_network_ipv6.py
ContextSuite context=TestNetworkPermissions>:setup	Error	0.00	test_network_permissions.py
test_delete_account	Error	1516.84	test_network.py
test_delete_network_while_vm_on_it	Error	1.24	test_network.py
test_deploy_vm_l2network	Error	1.25	test_network.py
test_l2network_restart	Error	2.39	test_network.py
ContextSuite context=TestPortForwarding>:setup	Error	3.63	test_network.py
ContextSuite context=TestPublicIP>:setup	Error	13.43	test_network.py
test_reboot_router	Failure	0.11	test_network.py
test_releaseIP	Error	6.86	test_network.py
test_releaseIP_using_IP	Error	6.99	test_network.py
ContextSuite context=TestRouterRules>:setup	Error	7.06	test_network.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	Error	1525.24	test_network.py
ContextSuite context=TestPrivateGwACL>:setup	Error	0.00	test_privategw_acl.py
ContextSuite context=TestAdapterTypeForNic>:setup	Error	0.00	test_nic_adapter_type.py
test_01_nic	Error	1516.46	test_nic.py
test_01_add_primary_storage_disabled_host	Error	1516.47	test_primary_storage.py
test_01_deploy_vms_storage_tags	Error	8.41	test_primary_storage.py
ContextSuite context=TestNonStrictAffinityGroups>:setup	Error	0.00	test_nonstrict_affinity_group.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup	Error	0.00	test_password_server.py
ContextSuite context=TestProjectSuspendActivate>:setup	Error	1528.55	test_projects.py

[weizhouapache]

@blueorangutan test ol8 xcpng82

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng82) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13398)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 82319 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10912-t13398-xcpng82.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_prepare_and_cancel_maintenance	Error	0.14	test_ms_maintenance_and_safe_shutdown.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	Error	1527.65	test_network.py

[Pearl1594]

Not sure how test suite TestSharedNetworkWithConfigDrive ran on 4.19 - because it doesn't exist. It was added in 4.20.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13512

[Pearl1594]

@blueorangutan package

[blueorangutan]

@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13513

[Pearl1594]

@blueorangutan test ol8 xcpng82

[blueorangutan]

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + xcpng82) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-13402)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 70857 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10912-t13402-xcpng82.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	Failure	741.90	test_kubernetes_clusters.py

[weizhouapache]

tested ok

vm can get data from ConfigDrive ISO

the only issues are,

• when attach an ISO, then new ISO is attached as the first ISO (the existing configdrive ISO is detached)
• when create a VM from ISO on a network with ConfigDrive, it will not work. I have not tested it yet.

Since the ConfigDrive issue has been broken for years, it looks like nobody has used it actually.

I would consider the issues above as known limitations and emphasize in the cloudstack documentation.
what do you think ? @Pearl1594 @DaanHoogland @rohityadavcloud

[Pearl1594]

Thanks Wei - I agree with what you say. We can document them as known issues for now and can look into fixing the issues in the next release.

[DaanHoogland]

• when attach an ISO, then new ISO is attached as the first ISO (the existing configdrive ISO is detached)
• when create a VM from ISO on a network with ConfigDrive, it will not work. I have not tested it yet.

I am adding remarks on these to the release notes for 4.19

[vladimirpetrov]

Another issue I've found is that the userdata functionality using config drive doesn't work.

[weizhouapache]

Another issue I've found is that the userdata functionality using config drive doesn't work.

@vladimirpetrov
I think this PR fixes it, isn't it ?