Conversation
|
Any update on this? |
|
|
||
| location ~ ^__PATH__/(?:index|remote|public|cron|core\/ajax\/update|status|ocs\/v[12]|updater\/.+|oc[ms]-provider\/.+|.+\/richdocumentscode\/proxy)\.php(?:$|\/) { | ||
| fastcgi_split_path_info ^(.+?\.php)(\/.*|)$; | ||
| location ~ ^__PATH__/(?:index|remote|public|cron|core\/ajax\/update|status|ocs\/v[12]|updater\/.+|oc[ms]-provider\/.+|.+\/richdocumentscode\/proxy)\.php(\/.*|)$ { |
There was a problem hiding this comment.
Could you explain why you need this change ? I remeber there was something around this on "15 to 18" PR
There was a problem hiding this comment.
From what I recall, otherwise accessing through the web browser just wasn't working... I couldn't figure out why (as it's the recommended configuration), so I got back to what worked...
| } | ||
|
|
||
| location ~ ^__PATH__/.+[^\/]\.(?:png|html|ttf|ico|jpg|jpeg|bcmap)$ { | ||
| location ~* \.(?:png|html|ttf|ico|jpg|jpeg|bcmap|mp4|webm)$ { |
There was a problem hiding this comment.
Could you explain why you need this change ? I remeber there was something around this on "15 to 18" PR
There was a problem hiding this comment.
Here it's just the application of the official recommendation
There was a problem hiding this comment.
It's a good addition, on the onboarding slides when you first access Nextcloud with your user, if you dont add mp4|webm locations you won't be able to play the video from the first slide. It's just an example of use.
There was a problem hiding this comment.
IMO, we should probably keep ~ ^__PATH__/.+[^\/]\.
|
We may want to upgrade directly to 19.0.1 as it corrects funny bugs like this one infinitely repeating LDPA search results with PHP <= 7.2 #21111 |
|
So... for someone who manually upgraded from 18.05 to 19.01 manually with Nextcloud's updater, is applying this upgrade in Yunohost likely to break anything? |
| } | ||
|
|
||
| location ~ ^__PATH__/.+[^\/]\.(?:png|html|ttf|ico|jpg|jpeg|bcmap)$ { | ||
| location ~* \.(?:png|html|ttf|ico|jpg|jpeg|bcmap|mp4|webm)$ { |
There was a problem hiding this comment.
| location ~* \.(?:png|html|ttf|ico|jpg|jpeg|bcmap|mp4|webm)$ { | |
| location ~ ^__PATH__/.+[^\/]\.(?:png|html|ttf|ico|jpg|jpeg|bcmap|mp4|webm)$ { |
Tested and working
kay0u
left a comment
There was a problem hiding this comment.
LGTM & code review, merging after the current testing
Problem
Solution
PR Status
Validation
Minor decision
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.