Skip to content

Add NTLMv1 flag on GPO#101

Open
Hackndo wants to merge 3 commits intoSpecterOps:v3from
Hackndo:v3
Open

Add NTLMv1 flag on GPO#101
Hackndo wants to merge 3 commits intoSpecterOps:v3from
Hackndo:v3

Conversation

@Hackndo
Copy link
Copy Markdown

@Hackndo Hackndo commented Feb 3, 2024

Similar to BloodHoundAD/SharpHound3#47

If GPO object forces LmCompatibilityLevel to be less than 3, then the computers it will be applied on will use NTLMv1 when authenticating.

This information seems very useful from an attacking perspective as authentication can be coerced and NTLMv1 hash cracked or relayed without MIC

(Also SpecterOps/SharpHound#87 on SharpHound)

image

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Hackndo
Copy link
Copy Markdown
Author

Hackndo commented Feb 3, 2024

I have read the CLA Document and I hereby sign the CLA

@rvazarkar
Copy link
Copy Markdown
Contributor

The implementation seems fine, but I'm sort of debating if it makes more sense to just merge this in with the existing gpo object processor stuff. @definitelynotagoblin @ddlees do either of you have any feelings on this? It is doing a bit more than our normal object processor does, but generally our processors are loosely linked to a particular collection method, so I think this would probably fit in ObjectProps instead

@JonasBK
Copy link
Copy Markdown
Contributor

JonasBK commented Jul 31, 2024

Hi @Hackndo,

Thank you for the two PRs - awesome work! 🙌

We have discussed internally and reached the conclusion that we would like to have two properties for this setting you collect:

  • LM Compatibility Level Raw (lmcompatibilitylevelraw)
  • LM Compatibility Level (lmcompatibilitylevel)

The raw property should hold the int value of the registry setting. The other one should hold a string with corresponding setting value i.e. one of these:

  • Send LM & NTLM responses
  • Send LM & NTLM - use NTLMv2 session security if negotiated
  • Send NTLM responses only
  • Send NTLMv2 responses only
  • Send NTLMv2 responses only. Refuse LM
  • Send NTLMv2 responses only. Refuse LM & NTLM

Are you interested in updating your PR to create those properties? If not, then we will merge your PRs in and we will make the changes on top such that your commits still end up in the git history.

Let me know what you think and thanks again for contributing!

@Hackndo
Copy link
Copy Markdown
Author

Hackndo commented Aug 1, 2024

Hello,
I'll update my PR in a few days.
Thank you for your feedback
Edit (2nd of August): There were major changes in LDAPUtils in v4. I'll need some time to wrap my head around this. :)

@JonasBK
Copy link
Copy Markdown
Contributor

JonasBK commented Sep 26, 2024

Hi @Hackndo,

Just checking if you are still interested in making the update to the PR :)

If not, we can still will merge your PRs in and make the changes on top such that your commits still end up in the git history.

@Hackndo
Copy link
Copy Markdown
Author

Hackndo commented Sep 26, 2024

Hey there. I still have this in mind but yes, maybe it will be better if you merge and add the necessary changes on top.
Thanks 👌

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 688eeead-a6cf-4502-90a0-7c6556cb3a84

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants