fix: set publish.yml CommonSource build property to stable BED-7878

[lrfalslev]

Description

Publishing should build against SHCommon stable version

Motivation and Context

This PR addresses: BED-7878

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Chore (a change that does not modify the application functionality)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have met the contributing prerequisites
  • Assigned myself to this PR
  • Added the appropriate labels
  • Associated an issue: Issues and Pull Requests README BloodHound#672
  • Read the Contributing guide: https://github.com/SpecterOps/BloodHound/wiki/Contributing
• I have ensured that related documentation is up-to-date
  • Open API docs
  • Code comments
• I have followed proper test practices
  • Added/updated tests to cover my changes
  • All new and existing tests passed

Summary by CodeRabbit

• Chores
  • Updated CI/CD workflow to use the latest checkout action for improved reliability and security.
  • Adjusted build configuration settings to optimize the release process.

[coderabbitai]

Walkthrough

Updated the CI workflow to upgrade the checkout action from v2 to v6 and modified the dotnet build command to set the CommonLibSource MSBuild property from Release to Stable.

Changes

Cohort / File(s)	Summary
CI Workflow Configuration .github/workflows/publish.yml	Updated actions/checkout from v2 to v6 and changed CommonLibSource MSBuild property from Release to Stable in the dotnet build step.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hop, hop, hooray! The workflow takes flight,
From v2 to v6, the checkout shines bright!
Release becomes Stable—a steady stance,
Our builds now dance the dependency dance! 🎯

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly reflects the main change: updating the publish.yml workflow to set the CommonLibSource property to stable, addressing ticket BED-7878.
Description check	✅ Passed	The description covers key sections including motivation, change type, and checklist completion, though the testing details section is incomplete.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch lfalslev/bed-7878

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/publish.yml:
- Line 39: The CI uses the wrong MSBuild property name: update the dotnet build
invocation that sets CommonLibSource to instead set CommonSource so the package
selection in Sharphound.csproj (which checks CommonSource) receives the intended
value; locate the dotnet build command (the line with "dotnet build -c ${{
matrix.release.type }} -p:Version=${VERSION:1}") and replace the
-p:CommonLibSource=... with -p:CommonSource=... so the stable/dev selection
works as expected.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 73916b67-f40a-4690-8b7b-8b45de0a36f4

📥 Commits

Reviewing files that changed from the base of the PR and between e35240b and 435958b.

📒 Files selected for processing (1)

• .github/workflows/publish.yml

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

Use the correct MSBuild property name (CommonSource)

Line 39 sets CommonLibSource, but package version selection in Sharphound.csproj is based on CommonSource (Sharphound.csproj:17-40). As written, this can leave the build on the default dev path instead of stable.

Proposed fix

-          dotnet build -c ${{ matrix.release.type }} -p:Version=${VERSION:1} -p:CommonLibSource=Stable
+          dotnet build -c ${{ matrix.release.type }} -p:Version=${VERSION:1} -p:CommonSource=Stable

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	dotnet build -c ${{ matrix.release.type }} -p:Version=${VERSION:1} -p:CommonLibSource=Stable
	dotnet build -c ${{ matrix.release.type }} -p:Version=${VERSION:1} -p:CommonSource=Stable

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/publish.yml at line 39, The CI uses the wrong MSBuild
property name: update the dotnet build invocation that sets CommonLibSource to
instead set CommonSource so the package selection in Sharphound.csproj (which
checks CommonSource) receives the intended value; locate the dotnet build
command (the line with "dotnet build -c ${{ matrix.release.type }}
-p:Version=${VERSION:1}") and replace the -p:CommonLibSource=... with
-p:CommonSource=... so the stable/dev selection works as expected.