Skip to content

(3.0.0 hotfix)#113

Merged
jcxldn merged 8 commits intomasterfrom
feat/jcx/2021/hotfix
Mar 30, 2021
Merged

(3.0.0 hotfix)#113
jcxldn merged 8 commits intomasterfrom
feat/jcx/2021/hotfix

Conversation

@jcxldn
Copy link
Copy Markdown
Member

@jcxldn jcxldn commented Mar 29, 2021

Hotfix: replace java with java-platform with an exclude for :serverversion

Issue:

  1. stickyapi-common depended on serverversion, which is not published
  2. stickyapi had no dependencies

Edit: if the root jar is now effectively a meta package (just a pom pointing to other modules) do we still need rootSources? 🤔

Issues

  • stickyapi X.X.X API title missing from aggregate javadocs
    • Now shows: StickyAPI X.X.X API (Aggregated)

@jcxldn jcxldn added help wanted Extra attention is needed dependencies Pull requests that update a dependency file breaking p0 bug Very high priority bug (server crashing etc) ops labels Mar 29, 2021
@jcxldn jcxldn requested a review from kaylendog March 29, 2021 16:41
@jcxldn jcxldn self-assigned this Mar 29, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2021

Codecov Report

Merging #113 (0873773) into master (c4d9c88) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   34.51%   34.51%           
=======================================
  Files          63       63           
  Lines        2532     2532           
  Branches      286      286           
=======================================
  Hits          874      874           
  Misses       1595     1595           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4d9c88...0873773. Read the comment docs.

Copy link
Copy Markdown
Collaborator

@kaylendog kaylendog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :3

@jcxldn jcxldn merged commit 00886ab into master Mar 30, 2021
@jcxldn jcxldn deleted the feat/jcx/2021/hotfix branch March 30, 2021 10:48
@jcxldn
Copy link
Copy Markdown
Member Author

jcxldn commented Mar 30, 2021

3.0.1 checklist (as of c232fa2)

  • Check stickyapi meta-pom (implementation platform("com.dumbdogdiner:stickyapi:3.0.1"))
runtimeClasspath - Runtime classpath of source set 'main'.
\--- com.dumbdogdiner:stickyapi:3.0.1
     +--- com.dumbdogdiner:stickyapi-bukkit:3.0.1
     |    +--- org.jetbrains:annotations:20.1.0
     |    +--- io.github.classgraph:classgraph:4.8.104
     |    +--- com.github.seancfoley:ipaddress:5.3.3
     |    \--- com.dumbdogdiner:stickyapi-common:3.0.1
     |         +--- org.jetbrains:annotations:20.1.0
     |         +--- io.github.classgraph:classgraph:4.8.104
     |         +--- com.github.seancfoley:ipaddress:5.3.3
     |         +--- com.google.code.gson:gson:2.8.6
     |         \--- com.dumbdogdiner:stickyapi-config:3.0.1
     |              +--- org.jetbrains:annotations:20.1.0
     |              +--- io.github.classgraph:classgraph:4.8.104
     |              \--- com.github.seancfoley:ipaddress:5.3.3
     +--- com.dumbdogdiner:stickyapi-bungee:3.0.1
     |    +--- org.jetbrains:annotations:20.1.0
     |    +--- io.github.classgraph:classgraph:4.8.104
     |    +--- com.github.seancfoley:ipaddress:5.3.3
     |    \--- com.dumbdogdiner:stickyapi-common:3.0.1 (*)
     +--- com.dumbdogdiner:stickyapi-common:3.0.1 (*)
     \--- com.dumbdogdiner:stickyapi-config:3.0.1 (*)
  • Check stickyapi-common (implementation "com.dumbdogdiner:stickyapi-common:3.0.1")
runtimeClasspath - Runtime classpath of source set 'main'.
\--- com.dumbdogdiner:stickyapi-common:3.0.1
     +--- org.jetbrains:annotations:20.1.0
     +--- io.github.classgraph:classgraph:4.8.104
     +--- com.github.seancfoley:ipaddress:5.3.3
     +--- com.google.code.gson:gson:2.8.6
     \--- com.dumbdogdiner:stickyapi-config:3.0.1
          +--- org.jetbrains:annotations:20.1.0
          +--- io.github.classgraph:classgraph:4.8.104
          \--- com.github.seancfoley:ipaddress:5.3.3
  • Check includes for stickyapi-common
  • Check includes for stickyapi-bukkit
  • Check sources for stickyapi (includes serverversion?)
  • Check sources for stickyapi-common (includes serverversion?)

@kaylendog kaylendog self-requested a review March 30, 2021 11:26
@jcxldn jcxldn removed the request for review from kaylendog March 30, 2021 11:26
Copy link
Copy Markdown
Collaborator

@kaylendog kaylendog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for merge?

@kaylendog
Copy link
Copy Markdown
Collaborator

Oop, spoke too late ><

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking dependencies Pull requests that update a dependency file help wanted Extra attention is needed ops p0 bug Very high priority bug (server crashing etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants