Skip to content

chore: remove legacy Grafana script#771

Merged
nicomiguelino merged 1 commit intomasterfrom
chore/remove-legacy-grafana-script
Apr 6, 2026
Merged

chore: remove legacy Grafana script#771
nicomiguelino merged 1 commit intomasterfrom
chore/remove-legacy-grafana-script

Conversation

@nicomiguelino
Copy link
Copy Markdown
Contributor

@nicomiguelino nicomiguelino commented Apr 6, 2026

User description

The Grafana Edge App (edge-apps/grafana) supersedes scripts/grafana/, which was a simple Python helper to add Grafana dashboards as URL assets. The Edge App covers the same use case with better integration and features.


PR Type

Other


Description

  • Remove legacy Grafana asset helper

  • Delete script README and usage docs

  • Drop obsolete Grafana script dependencies


Diagram Walkthrough

flowchart LR
  script["Legacy Grafana asset script"]
  docs["Script README documentation"]
  deps["Script Python dependencies"]
  removed["Removed from repository"]
  script -- "deleted" --> removed
  docs -- "deleted" --> removed
  deps -- "deleted" --> removed
Loading

File Walkthrough

Relevant files
Miscellaneous
add-grafana-asset.py
Delete obsolete Grafana asset helper                                         

scripts/grafana/add-grafana-asset.py

  • Remove the legacy Python helper script
  • Delete URL massaging and asset creation logic
  • Remove environment-based Grafana and Screenly integration
+0/-70   
Documentation
README.md
Remove deprecated script documentation                                     

scripts/grafana/README.md

  • Remove setup instructions for the legacy script
  • Delete usage examples and environment variable guidance
  • Eliminate documentation for deprecated Grafana workflow
+0/-31   
Dependencies
requirements.txt
Drop unused Grafana script dependencies                                   

scripts/grafana/requirements.txt

  • Delete script-only dependency declarations
  • Remove furl and requests requirements
+0/-2     

- The Grafana Edge App supersedes this script

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

PR Reviewer Guide 🔍

(Review updated until commit f3fe4fc)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the legacy scripts/grafana/ Python helper for adding Grafana dashboards as URL assets, since the Grafana Edge App (edge-apps/grafana) now covers the same use case with better integration.

Changes:

  • Deleted the legacy Grafana helper script (add-grafana-asset.py).
  • Removed the legacy script’s README and Python requirements file.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
scripts/grafana/requirements.txt Removes Python dependencies for the retired legacy script.
scripts/grafana/README.md Removes documentation for the retired legacy script.
scripts/grafana/add-grafana-asset.py Removes the retired legacy Grafana asset helper implementation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nicomiguelino nicomiguelino marked this pull request as ready for review April 6, 2026 02:23
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

Persistent review updated to latest commit f3fe4fc

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@nicomiguelino nicomiguelino merged commit b2a98c0 into master Apr 6, 2026
8 checks passed
@nicomiguelino nicomiguelino deleted the chore/remove-legacy-grafana-script branch April 6, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants