chore: remove legacy Grafana script#771
Merged
nicomiguelino merged 1 commit intomasterfrom Apr 6, 2026
Merged
Conversation
- The Grafana Edge App supersedes this script Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PR Reviewer Guide 🔍(Review updated until commit f3fe4fc)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy scripts/grafana/ Python helper for adding Grafana dashboards as URL assets, since the Grafana Edge App (edge-apps/grafana) now covers the same use case with better integration.
Changes:
- Deleted the legacy Grafana helper script (
add-grafana-asset.py). - Removed the legacy script’s README and Python requirements file.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/grafana/requirements.txt | Removes Python dependencies for the retired legacy script. |
| scripts/grafana/README.md | Removes documentation for the retired legacy script. |
| scripts/grafana/add-grafana-asset.py | Removes the retired legacy Grafana asset helper implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Persistent review updated to latest commit f3fe4fc |
PR Code Suggestions ✨No code suggestions found for the PR. |
salmanfarisvp
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
The Grafana Edge App (
edge-apps/grafana) supersedesscripts/grafana/, which was a simple Python helper to add Grafana dashboards as URL assets. The Edge App covers the same use case with better integration and features.PR Type
Other
Description
Remove legacy Grafana asset helper
Delete script README and usage docs
Drop obsolete Grafana script dependencies
Diagram Walkthrough
File Walkthrough
add-grafana-asset.py
Delete obsolete Grafana asset helperscripts/grafana/add-grafana-asset.py
README.md
Remove deprecated script documentationscripts/grafana/README.md
requirements.txt
Drop unused Grafana script dependenciesscripts/grafana/requirements.txt
furlandrequestsrequirements