Conversation
BennoLossin
previously requested changes
Apr 14, 2026
Member
BennoLossin
left a comment
There was a problem hiding this comment.
Thanks for doing this :)
We should also now record the minimum rust version in the Cargo.toml.
Member
Author
|
QEMU has MSRV of 1.83. It doesn't yet use pin-init, but could, so I decided to keep MSRV at 1.82 unless we have a specific reason to bump past it. |
BennoLossin
approved these changes
Apr 16, 2026
Member
BennoLossin
left a comment
There was a problem hiding this comment.
I agree that bumping to only 1.82 is better, since we don't need anything from a higher version.
Following the kernel minimum version bump in f32fb9c58a5b ("rust: bump Rust
minimum supported version to 1.85.0 (Debian Trixie)"), bump pin-init's
minimum Rust version to 1.82.
This removes the `lint_reasons` feature which is stabilized in 1.81 and the
`raw_ref_ops` and `new_uninit` features which are stabilized in 1.82.
Given we do not use any features that are stabilized in 1.82..=1.85 range,
and pin-init crate is useful for other projects which may have their own
MSRV requirements, the minimum version is not straightly bumped to 1.85.
Signed-off-by: Gary Guo <gary@garyguo.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the kernel minimum version bump in f32fb9c58a5b ("rust: bump Rust minimum supported version to 1.85.0 (Debian Trixie)"), pin-init can bump its minimum version to 1.85, too.
This removes the
lint_reasonsfeature which is stabilized in 1.81 and theraw_ref_opsandnew_uninitfeatures which are stabilized in 1.82.