Unit tests fail on Windows

[kevinushey]

From WinBuilder with R-release:

* checking tests ...
** running tests for arch 'i386' ERROR
Running the tests in 'tests/doRUnit.R' failed.
Last 13 lines of output:
  > pkg <- "Rcpp"

  > if (require("RUnit", quietly = TRUE)) {
  +     is_local <- function() {
  +         if (exists("argv", globalenv()) && "--local" %in% argv) 
  +          .... [TRUNCATED] 


  Executing test function test.DataFrame.AttributeProxy  ... 
  This application has requested the Runtime to terminate it in an unusual way.
  Please contact the application's support team for more information.
  terminate called after throwing an instance of 'Rcpp::eval_error'
    what():  cannot coerce class ""function"" to a data.frame
** running tests for arch 'x64' ERROR
Running the tests in 'tests/doRUnit.R' failed.
Last 13 lines of output:
  > pkg <- "Rcpp"

  > if (require("RUnit", quietly = TRUE)) {
  +     is_local <- function() {
  +         if (exists("argv", globalenv()) && "--local" %in% argv) 
  +          .... [TRUNCATED] 


  Executing test function test.DataFrame.AttributeProxy  ... 
  This application has requested the Runtime to terminate it in an unusual way.
  Please contact the application's support team for more information.
  terminate called after throwing an instance of 'Rcpp::eval_error'
    what():  cannot coerce class ""function"" to a data.frame

Seems like there is something funky going on with Rcpp's exceptions, at least as far as Windows is concerned.

[romainfrancois]

@kevinushey as usual R CMD check last 13 lines of output is useless. Is there more information available ?

[romainfrancois]

I ran my own win builder, but no luck, not much more meaningful information.
http://win-builder.r-project.org/g0RO6L0KVsRR/examples_and_tests/tests_i386/doRUnit.Rout.fail

[kevinushey]

It looks like you're on top if it, but just in case, here's output with RCPP_DEBUG_LEVEL=1 set.

                           Rcpp/as.h:  79 as(SEXP = <0x07640da8>, r_type_generic_tag )
                           Rcpp/as.h:  81 exporter type = Rcpp::traits::Exporter<Rcpp::Vector<19, Rcpp::PreserveStorage> >
                Rcpp/vector/Vector.h: 389 VECTOR<19>::init( SEXP = <0x07650c98> )
                Rcpp/internal/wrap.h: 897 inline SEXP wrap<Rcpp::AttributeProxyPolicy<Rcpp::Vector<19, Rcpp::PreserveStorage> >::AttributeProxy>(const T& object)
                Rcpp/internal/wrap.h: 798 wrap_dispatch<Rcpp::AttributeProxyPolicy<Rcpp::Vector<19, Rcpp::PreserveStorage> >::AttributeProxy>(., wrap_type_unknown_tag )
                Rcpp/internal/wrap.h: 778 wrap_dispatch_unknown_importable<Rcpp::AttributeProxyPolicy<Rcpp::Vector<19, Rcpp::PreserveStorage> >::AttributeProxy>(., false  )
                Rcpp/internal/wrap.h: 761 wrap_dispatch_eigen<Rcpp::AttributeProxyPolicy<Rcpp::Vector<19, Rcpp::PreserveStorage> >::AttributeProxy>(., false  )
                Rcpp/internal/wrap.h: 498 wrap_dispatch_unknown<Rcpp::AttributeProxyPolicy<Rcpp::Vector<19, Rcpp::PreserveStorage> >::AttributeProxy>(., false  )
                Rcpp/internal/wrap.h: 897 inline SEXP wrap<Rcpp::DataFrame_Impl<Rcpp::PreserveStorage>>(const T& object)
                Rcpp/internal/wrap.h: 798 wrap_dispatch<Rcpp::DataFrame_Impl<Rcpp::PreserveStorage>>(., wrap_type_unknown_tag )
                Rcpp/internal/wrap.h: 778 wrap_dispatch_unknown_importable<Rcpp::DataFrame_Impl<Rcpp::PreserveStorage>>(., false  )
                Rcpp/internal/wrap.h: 761 wrap_dispatch_eigen<Rcpp::DataFrame_Impl<Rcpp::PreserveStorage>>(., false  )
                Rcpp/internal/wrap.h: 498 wrap_dispatch_unknown<Rcpp::DataFrame_Impl<Rcpp::PreserveStorage>>(., false  )
                           Rcpp/as.h:  79 as(SEXP = <0x07640da8>, r_type_generic_tag )
                           Rcpp/as.h:  81 exporter type = Rcpp::traits::Exporter<Rcpp::Vector<19, Rcpp::PreserveStorage> >
                Rcpp/vector/Vector.h: 389 VECTOR<19>::init( SEXP = <0x075b27c0> )
                Rcpp/internal/wrap.h: 897 inline SEXP wrap<Rcpp::AttributeProxyPolicy<Rcpp::Vector<19, Rcpp::PreserveStorage> >::AttributeProxy>(const T& object)
                Rcpp/internal/wrap.h: 798 wrap_dispatch<Rcpp::AttributeProxyPolicy<Rcpp::Vector<19, Rcpp::PreserveStorage> >::AttributeProxy>(., wrap_type_unknown_tag )
                Rcpp/internal/wrap.h: 778 wrap_dispatch_unknown_importable<Rcpp::AttributeProxyPolicy<Rcpp::Vector<19, Rcpp::PreserveStorage> >::AttributeProxy>(., false  )
                Rcpp/internal/wrap.h: 761 wrap_dispatch_eigen<Rcpp::AttributeProxyPolicy<Rcpp::Vector<19, Rcpp::PreserveStorage> >::AttributeProxy>(., false  )
                Rcpp/internal/wrap.h: 498 wrap_dispatch_unknown<Rcpp::AttributeProxyPolicy<Rcpp::Vector<19, Rcpp::PreserveStorage> >::AttributeProxy>(., false  )

[romainfrancois]

So this is about exceptions crossing boundaries again. Presumably because of this funciton:

inline SEXP convert_using_rfunction(SEXP x, const char* const fun){
            Armor<SEXP> res ;
            try{
                SEXP funSym = Rf_install(fun);
                res = Rcpp_eval( Rf_lang2( funSym, x ) ) ;
            } catch( eval_error& e){
                throw not_compatible( std::string("could not convert using R function : ") + fun  ) ;
            }
            return res;
        }

Here Rcpp_eval is registered and throws an exception which is supposed to be caught, but since windows does not handle exceptions crossing boundaries, we get what we get.

Next is to try to unregister Rcpp_eval (i.e. inline it) and see what happens.

We might have to look at all the functions that are RCPP_REGISTERed to see if they throw, ... because apparently that can't happen on windows.

[romainfrancois]

@kevinushey The problem with RCPP_DEBUG ... is that RCPP_DEBUG calls have been added here and there in response to certain issues we had at some point, so they might not be informative enough on a new issue.

We have to navigate the code and add new RCPP_DEBUG calls where it makes sense.

[romainfrancois]

I have unregistered Rcpp_eval in this commit. fcc08ae

The process is pretty simple:

• moving the function to an inline function some place in the headers, e.g. in meat in this example
• rm the RCPP_REGISTER call in Rcpp_init.cpp
• rm the two places where the function is seen in routines.

[romainfrancois]

Fixed. see
http://win-builder.r-project.org/xLHhTA6IIw9Y/examples_and_tests/tests_i386/Rcpp-unitTests.html
http://win-builder.r-project.org/xLHhTA6IIw9Y/examples_and_tests/tests_x64/Rcpp-unitTests.html