Skip to content

refactor: cleanup preloader#8518

Open
maiieul wants to merge 16 commits intobuild/v2from
cleanup-preloader-queue
Open

refactor: cleanup preloader#8518
maiieul wants to merge 16 commits intobuild/v2from
cleanup-preloader-queue

Conversation

@maiieul
Copy link
Copy Markdown
Member

@maiieul maiieul commented Apr 3, 2026

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Removing deprecated APIs as well as unnecessary ones. Cleaning up old logic to reduce code size and make it easier to inline the preloader logic in a future refactor.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@maiieul maiieul requested a review from a team as a code owner April 3, 2026 11:54
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 3, 2026

🦋 Changeset detected

Latest commit: d268e21

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul maiieul self-assigned this Apr 3, 2026
@maiieul maiieul moved this to Waiting For Review in Qwik Development Apr 3, 2026
@maiieul maiieul marked this pull request as draft April 3, 2026 12:14
@maiieul maiieul moved this from Waiting For Review to In progress in Qwik Development Apr 3, 2026
@maiieul maiieul force-pushed the cleanup-preloader-queue branch from a50429b to 2404ee4 Compare April 3, 2026 12:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview d268e21

@maiieul maiieul force-pushed the cleanup-preloader-queue branch 2 times, most recently from 1664964 to 7a00e94 Compare April 3, 2026 15:33
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 6, 2026

Open in StackBlitz

@qwik.dev/core

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8518

@qwik.dev/router

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8518

eslint-plugin-qwik

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8518

create-qwik

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8518

@qwik.dev/optimizer

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/optimizer@8518

commit: 0ab8b68

@maiieul maiieul force-pushed the cleanup-preloader-queue branch 2 times, most recently from 3921b72 to dc93fbd Compare April 6, 2026 13:58
@maiieul maiieul changed the title refactor: cleanup queue.ts refactor: cleanup preloader Apr 6, 2026
@maiieul maiieul added the V2 label Apr 6, 2026
@maiieul maiieul marked this pull request as ready for review April 6, 2026 14:48
@maiieul maiieul requested review from a team as code owners April 6, 2026 14:48
@maiieul maiieul moved this from In progress to Waiting For Review in Qwik Development Apr 6, 2026
@maiieul maiieul force-pushed the cleanup-preloader-queue branch from 0ab8b68 to 258b2ba Compare April 17, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Waiting For Review

Development

Successfully merging this pull request may close these issues.

1 participant