Open
Conversation
Co-authored-by: Bethany Nicholson <blnicho@users.noreply.github.com>
Co-authored-by: John Siirola <jsiirola@users.noreply.github.com>
Co-authored-by: John Siirola <jsiirola@users.noreply.github.com>
Co-authored-by: John Siirola <jsiirola@users.noreply.github.com>
Co-authored-by: John Siirola <jsiirola@users.noreply.github.com>
Co-authored-by: John Siirola <jsiirola@users.noreply.github.com>
…'vars_in_kkt_cons'.
Co-authored-by: John Siirola <jsiirola@users.noreply.github.com>
…mo into kkt-transform need to fix merge conflicts.
Author
Closed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3881 +/- ##
========================================
Coverage 89.93% 89.94%
========================================
Files 902 903 +1
Lines 106393 106503 +110
========================================
+ Hits 95683 95791 +108
- Misses 10710 10712 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jsiirola
requested changes
Mar 25, 2026
Member
jsiirola
left a comment
There was a problem hiding this comment.
This is really close! Just a couple minor changes...
Co-authored-by: John Siirola <jsiirola@users.noreply.github.com>
… to reflect this.
…or ipopt to relevant tests.
jsiirola
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Summary/Motivation:
This PR refactors the KKT transformation code (see PR #3860) to make it more efficient. In the original PR, it was suggested by @jsiirola that the order of operations be reversed to avoid repeated work and the use of unintuitive data structures.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: