Skip to content

Fixed master server spam by excluding servers that don't ping back#29

Merged
ihptru merged 1 commit intoOpenRA:masterfrom
Mailaender:antispam
Dec 19, 2014
Merged

Fixed master server spam by excluding servers that don't ping back#29
ihptru merged 1 commit intoOpenRA:masterfrom
Mailaender:antispam

Conversation

@Mailaender
Copy link
Copy Markdown
Member

I first thought about inventing a new ServerState.NotResponding to get rid of the [down] prefix, but than why should we even list those especially when it is a good opportunity to finally fix #5.

@Mailaender Mailaender mentioned this pull request Dec 6, 2014
@ihptru
Copy link
Copy Markdown
Contributor

ihptru commented Dec 6, 2014

what is this? this does not fix either #5 or proposed #29
this only updates games.txt file with counter, just on different condition.

@Mailaender Mailaender force-pushed the antispam branch 3 times, most recently from bb43371 to dc407c0 Compare December 6, 2014 16:23
@Mailaender
Copy link
Copy Markdown
Member Author

I updated this a couple of times. Tried to create a test area at http://master.openra.net/staging/ but this is tricky to debug. Not sure if this really works how I want.

@ihptru
Copy link
Copy Markdown
Contributor

ihptru commented Dec 18, 2014

Looks good, the only thing I noticed about OpenRA Server, is that it will dequeue "Master Server communication established" and will keep pinging Master server, endlessly getting 'server ... does not respond' in background. Maybe add some error code to response of master server and parse it on OpenRA side to stop pinging it?

@ihptru
Copy link
Copy Markdown
Contributor

ihptru commented Dec 18, 2014

it's 👍 though, for current version. Also want to see how well it will work in production.

With current realization, there will be no more games in server browser with closed ports. And for server hosters with not forwarded ports, message "Master server communication established" and no evidence of their server online, there will be a definite answer to forward ports.

ihptru added a commit that referenced this pull request Dec 19, 2014
Fixed master server spam by excluding servers that don't ping back
@ihptru ihptru merged commit bafd896 into OpenRA:master Dec 19, 2014
@ihptru
Copy link
Copy Markdown
Contributor

ihptru commented Dec 19, 2014

Just basic information which can be useful in future (following the result behavior after merging it, and the next PR following after it (#30)):

Started games with closed ports are still advertised. (Appeared that default socket test function in php fails for any started OpenRA game with closed or opened ports).

Also, with this PR, servers with not forwarded ports automatically does NOT added to tables: started, finished and map_stats

@Mailaender Mailaender deleted the antispam branch August 27, 2016 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

list.php Can be Spammed

2 participants