Fixed master server spam by excluding servers that don't ping back#29
Fixed master server spam by excluding servers that don't ping back#29ihptru merged 1 commit intoOpenRA:masterfrom
Conversation
bb43371 to
dc407c0
Compare
|
I updated this a couple of times. Tried to create a test area at http://master.openra.net/staging/ but this is tricky to debug. Not sure if this really works how I want. |
|
Looks good, the only thing I noticed about OpenRA Server, is that it will dequeue "Master Server communication established" and will keep pinging Master server, endlessly getting 'server ... does not respond' in background. Maybe add some error code to response of master server and parse it on OpenRA side to stop pinging it? |
|
it's 👍 though, for current version. Also want to see how well it will work in production. With current realization, there will be no more games in server browser with closed ports. And for server hosters with not forwarded ports, message "Master server communication established" and no evidence of their server online, there will be a definite answer to forward ports. |
Fixed master server spam by excluding servers that don't ping back
|
Just basic information which can be useful in future (following the result behavior after merging it, and the next PR following after it (#30)): Started games with closed ports are still advertised. (Appeared that default socket test function in php fails for any started OpenRA game with closed or opened ports). Also, with this PR, servers with not forwarded ports automatically does NOT added to tables: |
I first thought about inventing a new
ServerState.NotRespondingto get rid of the[down]prefix, but than why should we even list those especially when it is a good opportunity to finally fix #5.