Add transaction filtering support to eth_call#4613
Open
MishkaRogachev wants to merge 10 commits intomasterfrom
Open
Add transaction filtering support to eth_call#4613MishkaRogachev wants to merge 10 commits intomasterfrom
MishkaRogachev wants to merge 10 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4613 +/- ##
==========================================
+ Coverage 33.82% 34.70% +0.88%
==========================================
Files 499 499
Lines 60170 60170
==========================================
+ Hits 20350 20880 +530
+ Misses 36272 35598 -674
- Partials 3548 3692 +144 |
Contributor
❌ 15 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds system-level coverage and backend wiring needed to support address-based transaction filtering in eth_call, aligning it with existing eth_estimateGas filtering behavior (NIT-4725; pulls in OffchainLabs/go-ethereum#647).
Changes:
- Adds new system tests validating
eth_callfiltering (enabled/disabled) and ensuring filtering doesn’t mutateeth_callreturn values when scheduled txes (retryable redeems) execute. - Consolidates prior estimate-gas filtering tests into a new combined RPC filtering test file (and removes the old dedicated estimate-gas test file).
- Updates the geth execution
txFiltererimplementation to the revisedcore.TxFilterermethod set (split touch logic and post-execution filtering check), and adds a changelog entry.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| system_tests/rpc_filter_test.go | New consolidated system tests for eth_estimateGas + eth_call filtering, including scheduled-tx (retryable) eth_call result stability. |
| system_tests/estimate_gas_filter_test.go | Removes the old estimate-gas-only filtering tests (superseded by rpc_filter_test.go). |
| execution/gethexec/tx_filterer.go | Updates txFilterer method names/signatures to match the updated TxFilterer interface and separates direct from/to touching vs scheduled-tx touching. |
| changelog/mrogachev-nit-4725.md | Documents the internal change adding eth_call address filtering support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+244
to
+254
| // Craft eth_call data: ArbRetryableTx.redeem(ticketId) | ||
| arbRetryableABI, err := precompilesgen.ArbRetryableTxMetaData.GetAbi() | ||
| Require(t, err) | ||
| redeemData, err := arbRetryableABI.Pack("redeem", ticketId) | ||
| Require(t, err) | ||
| arbRetryableAddr := common.HexToAddress("0x6e") | ||
|
|
||
| callMsg := ethereum.CallMsg{ | ||
| From: userAddr, | ||
| To: &arbRetryableAddr, | ||
| Data: redeemData, |
There was a problem hiding this comment.
Prefer using the canonical ArbRetryableTx precompile address constant (e.g., types.ArbRetryableTxAddress) instead of hard-coding 0x6e. This avoids magic numbers and stays correct if the address is ever refactored/centralized differently (several system tests already use the constant).
diegoximenes
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close NIT-4725
Pulls in OffchainLabs/go-ethereum#647
Add transaction filtering support to eth_call and polish TxFilterer Interface