fix: aggregate rollout metrics by semantic type (min/max/sum/mean)#2175
Open
fix: aggregate rollout metrics by semantic type (min/max/sum/mean)#2175
Conversation
Previously all numeric rollout metrics were averaged when aggregating across trajectory groups, giving misleading values for min/max/total metrics. Now min-prefixed/suffixed metrics use min(), max uses max(), total_turns is summed, and the rest are averaged. Extracts `aggregate_rollout_metrics()` helper for testability and adds unit tests covering each aggregation path. Closes #1955 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
8bb0339 to
3b197f3
Compare
yuki-97
reviewed
Mar 31, 2026
| for k, v in rollout_metrics.items() | ||
| } | ||
| per_group_metrics.setdefault(k, []).append(v) | ||
| rollout_metrics = aggregate_rollout_metrics(per_group_metrics) |
Contributor
There was a problem hiding this comment.
just curious, don't we need to add this in the sync grpo path as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously all numeric rollout metrics were averaged when aggregating across trajectory groups, giving misleading values for min/max/total metrics. Now min-prefixed/suffixed metrics use min(), max uses max(), total_turns is summed, and the rest are averaged.
Extracts
aggregate_rollout_metrics()helper for testability and adds unit tests covering each aggregation path.Closes #1955
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information