Skip to content

Chore: [AEA-0000] - use name:tag for syft, grype, grant containers#78

Merged
anthony-nhs merged 1 commit intomainfrom
fix_release
Apr 1, 2026
Merged

Chore: [AEA-0000] - use name:tag for syft, grype, grant containers#78
anthony-nhs merged 1 commit intomainfrom
fix_release

Conversation

@anthony-nhs
Copy link
Copy Markdown
Contributor

Summary

  • Routine Change

Details

  • use name:tag for syft, grype, grant containers

Copilot AI review requested due to automatic review settings April 1, 2026 12:01
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

This PR is linked to a ticket in an NHS Digital JIRA Project. Here's a handy link to the ticket:

AEA-0000

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the devcontainer build chain explicitly reference locally-built Syft/Grype/Grant images using the name:tag form (specifically :latest) so the FROM stages and Makefile build targets are consistent and explicit.

Changes:

  • Update src/base/.devcontainer/Dockerfile to use local_syft:latest, local_grype:latest, and local_grant:latest in multi-stage FROM lines.
  • Update Makefile build targets to tag the locally-built images as :latest to match the Dockerfile.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/base/.devcontainer/Dockerfile Switch multi-stage FROM references to local_*:latest for explicit name:tag usage.
Makefile Tag locally built syft/grype/grant images as local_*:latest to align with Dockerfile stages.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@anthony-nhs anthony-nhs merged commit c097477 into main Apr 1, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants