Catch all exceptions when removing view#218
Merged
xiphirx merged 1 commit intoKeepSafe:masterfrom Oct 17, 2017
Jawnnypoo:out-of-bounds
Merged
Catch all exceptions when removing view#218xiphirx merged 1 commit intoKeepSafe:masterfrom Jawnnypoo:out-of-bounds
xiphirx merged 1 commit intoKeepSafe:masterfrom
Jawnnypoo:out-of-bounds
Conversation
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #207
I think probably what is happening is that the view is already destroyed and removed, and we are attempting to remove it again. We could put a check in here to make sure the child is still attached to the parent before attempting to remove, but I think since we already have this needed try/catch, it might as well be made more broad to account for this.